Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched out names for dimnames #83

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Switched out names for dimnames #83

merged 2 commits into from
Nov 25, 2019

Conversation

Tokazama
Copy link
Contributor

Fixes #22

Copy link
Contributor

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I know it wasn't exported, but i suspect some folks were using NamedDims.names, so let's add a deprecation to be generous:

@deprecate names dimnames false

Also bump the patch version so we can tag a release :)

@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files           8        8           
  Lines         284      284           
=======================================
  Hits          250      250           
  Misses         34       34
Impacted Files Coverage Δ
src/NamedDims.jl 100% <ø> (ø) ⬆️
src/functions_math.jl 97.56% <100%> (ø) ⬆️
src/functions.jl 98.21% <100%> (ø) ⬆️
src/functions_dims.jl 100% <100%> (ø) ⬆️
src/broadcasting.jl 57.57% <50%> (ø) ⬆️
src/wrapper_array.jl 90.24% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51893cf...c434bca. Read the comment docs.

@nickrobinson251
Copy link
Contributor

nickrobinson251 commented Nov 23, 2019

LGTM!

I am fine with dimnames as the name, but... before we go ahead I wanted to just raise the possibility of simply calling this dims, in case anyone else also preferred that? (Will merge tomorrow at the latest if no one else has thoughts)

@oxinabox
Copy link
Member

dims to me feels like it should return numbers

@mcabbott mcabbott mentioned this pull request Nov 23, 2019
@nickrobinson251 nickrobinson251 merged commit ef8d143 into invenia:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Used Base.names
3 participants