Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop making Tracker loading depend on version #57

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

nickrobinson251
Copy link
Contributor

- No reliable way to identify the version
- More useful to assume a compatible Tracker
@nickrobinson251 nickrobinson251 requested a review from oxinabox June 25, 2019 15:23
@oxinabox
Copy link
Member

Possibly solution in JuliaPackaging/Requires.jl#3 (comment)
but I would rather push that into Requires than do it here.
So lets do this

@oxinabox oxinabox closed this Jun 25, 2019
@oxinabox oxinabox reopened this Jun 25, 2019
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #57 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   85.97%   86.11%   +0.13%     
==========================================
  Files           8        8              
  Lines         221      216       -5     
==========================================
- Hits          190      186       -4     
+ Misses         31       30       -1
Impacted Files Coverage Δ
src/NamedDims.jl 100% <100%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33cdb6c...1ab3b9a. Read the comment docs.

src/NamedDims.jl Outdated Show resolved Hide resolved
Co-Authored-By: Lyndon White <[email protected]>
@nickrobinson251 nickrobinson251 merged commit 31a8195 into invenia:master Jun 25, 2019
@nickrobinson251 nickrobinson251 deleted the npr/tracker-no-check branch July 2, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants