[Speculative] Recursively look for names inside wrapper types #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # things that are not wrapper arrays are there own parents, | ||
| # so at that point we can give up looking for names | ||
| # also we have no way to deal with inner arrays of different dimensions, even if they do have names | ||
| # so give up then too |
There was a problem hiding this comment.
maybe helpful to add an example (cos it's a bit of a weird case)? e.g.
also parent arrays can have a different number of dimensions, e.g. parent of a
Diagonalis aVector
we have no way to deal with the names in this case so give up then too
| end | ||
| end | ||
| names(x::Array{T,N}) where {T,N} = default_names(x) # shortcut of the above | ||
| default_names(x::AbstractArray{T, N}) where {T,N} = ntuple(_->:_, N) |
There was a problem hiding this comment.
Are these really the names of an un-named thing?
Aren't these the names of something which has names, they're just unknown/wildcards
The names of an unnamed thing is nothing or maybe ntuple(i -> nothing, N)?
|
I like this as an idea, although I disagree with assigning names (even wildcards) to non-named things. We should only gain wildcards if we cannot know the appropriate new name(s) for a previously named thing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idk if this is a good idea,
Goal would be for better handling of things like
LowerTriangular{<:NamedDimsArray}