Add more tests #39
Merged
Add more tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
+ Coverage 95.63% 96.93% +1.3%
=========================================
Files 10 10
Lines 206 196 -10
=========================================
- Hits 197 190 -7
+ Misses 9 6 -3
Continue to review full report at Codecov.
|
rofinn
force-pushed
the
rf/moar-tests
branch
2 times, most recently
from
13d636e to
39a1de6
Compare
| rowtab_ = Impute.dropobs!(rowtab; context=ctx) | ||
| # The mutating test is broken because we need to making a copy of | ||
| # the original table | ||
| # @test_broken isequal(rowtab, expected) |
There was a problem hiding this comment.
Suggested change
| # @test_broken isequal(rowtab, expected) | |
| @test_broken isequal(rowtab, expected) |
There was a problem hiding this comment.
Fun fact, this test isn't broken :D
There was a problem hiding this comment.
can you please add a comment on that? (I didn't understand from the current comment why this test was commented out)
nickrobinson251
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30 and #27.
NOTE: Since dropobs requires that
parent(data) === datayou may find unexpected behaviour when working with wrapper array types where it'll return the parent type rather than the wrapper type. I'm not sure if there is a good way around this sincesetparent!isn't a thing.