Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concentration as query param #292

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from
Open

Add concentration as query param #292

wants to merge 20 commits into from

Conversation

kuba80-02
Copy link
Contributor

No description provided.

@kuba80-02 kuba80-02 changed the base branch from master to dev December 24, 2024 09:09
wojciech-cichocki
wojciech-cichocki requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the concentration level in the UI do not update the URL. It currently works only one way—changes to the URL update the UI. It should work both ways

wojciech-cichocki
wojciech-cichocki requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 40x as default concentration

wojciech-cichocki
wojciech-cichocki requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can take advantage of the fact that the concentration level is stored in the URL when switching from "concentration" to "range" mode. This stored level can then be used to restore the previous concentration level when switching back from "range" mode to "concentration." Currently, the concentration level is reset to 2x by default

Screencast.from.30.12.2024.07.02.39.webm

@p6te
Copy link
Collaborator

p6te commented Dec 30, 2024

Nagranie ekranu z 30.12.2024 10:08:32.webm
when you open pair without pool, the concentration is not shown in URL

@p6te
Copy link
Collaborator

p6te commented Dec 30, 2024

Nagranie ekranu z 30.12.2024 10:07:47.webm
on new pool view, concentration is not updated in URL, when it is changed

@p6te
Copy link
Collaborator

p6te commented Dec 30, 2024

Nagranie ekranu z 30.12.2024 10:17:31.webm
when i redirect to add position from pool links, the concentration is often set to max possible. should it be set to 40x?

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 3f960bc
✅ Preview: https://webapp-eclipse-8c5hqf9za-invariantlabs.vercel.app
🔍 Inspect: https://vercel.com/invariantlabs/webapp-eclipse/Y23dAQEnxHTu9w4ofguV9MY2B9b5

View Workflow Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciech-cichocki wojciech-cichocki wojciech-cichocki requested changes

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuba80-02 @p6te @wojciech-cichocki