replace connect modal for connect button on new position page #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p6te
reviewed
Sep 19, 2024
p6te
reviewed
Sep 19, 2024
wojciech-cichocki
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Jumping position of button: "Connect wallet" and "Add position"
Screencast from 19.09.2024 12:44:52.webm
wojciech-cichocki
requested changes
Sep 21, 2024
wojciech-cichocki
requested changes
Sep 22, 2024
There was a problem hiding this comment.
Is there a need to trigger a loader for the token balance in case the wallet is disconnected? There should always be a -" value:
Screencast from 22.09.2024 22:44:52.webm
p6te
approved these changes
Sep 23, 2024
p6te
reviewed
Sep 23, 2024
p6te
approved these changes
Sep 23, 2024
wojciech-cichocki
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Bug with token balances after triggering refresh:
Screencast from 23.09.2024 14:50:20.webm
|
This pull request has been deployed to Vercel.
|
p6te
approved these changes
Sep 24, 2024
wojciech-cichocki
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.