Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console errors and improve seo #252

Merged
merged 7 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"dependencies": {
"@emotion/react": "^11.11.4",
"@emotion/styled": "^11.11.5",
"@invariant-labs/a0-sdk": "^0.2.11",
"@invariant-labs/a0-sdk": "^0.2.15",
"@mui/icons-material": "^5.15.15",
"@mui/material": "^5.15.15",
"@nightlylabs/wallet-selector-polkadot": "^0.2.5",
Expand Down
2 changes: 1 addition & 1 deletion src/components/Modals/Slippage/Slippage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const Slippage: React.FC<Props> = ({
<Grid container className={classes.detailsWrapper}>
<Grid container justifyContent='space-between' style={{ marginBottom: 6 }}>
<Typography component='h2'>{headerText ?? 'Exchange Settings'}</Typography>
<Button className={classes.selectTokenClose} onClick={handleClose} />
<Button className={classes.selectTokenClose} onClick={handleClose} aria-label='Close' />
</Grid>
<Typography className={classes.label}>Slippage tolerance</Typography>
<Grid container gap='9px'>
Expand Down
2 changes: 1 addition & 1 deletion src/components/NewPosition/NewPosition.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ export const NewPosition: React.FC<INewPosition> = ({
) : null}
<Grid className={classes.optionsWrapper}>
<Hidden mdDown>
{poolKey !== '' && (
{tokenAIndex !== null && tokenBIndex !== null && (
<ConcentrationTypeSwitch
onSwitch={val => {
if (val) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/NewPosition/RangeSelector/RangeSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ export const RangeSelector: React.FC<IRangeSelector> = ({
? cachedConcentrationArray.length - 1
: concentrationIndex
setConcentrationIndex(index)
console.log('test')

const { leftRange, rightRange } = calculateConcentrationRange(
tickSpacing,
cachedConcentrationArray[index],
Expand Down
8 changes: 6 additions & 2 deletions src/components/NewPosition/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ const useStyles = makeStyles()(theme => {
}
},
switch: {
transition: 'opacity 500ms'
transition: 'opacity 500ms',
display: 'flex',
justifyContent: 'flex-end'
},
titleContainer: {
maxWidth: 464,
Expand All @@ -122,7 +124,9 @@ const useStyles = makeStyles()(theme => {
},
optionsWrapper: {
display: 'flex',
alignItems: 'center'
alignItems: 'center',
flex: 1,
justifyContent: 'flex-end'
}
}
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ const SinglePositionInfo: React.FC<IProp> = ({
/>
<img
className={classes.arrowIcon}
src={icons.ArrowIcon}
alt={'Arrow'}
src={icons.swapListIcon}
alt='Reverse tokens'
onClick={swapHandler}
/>
<img
Expand Down
7 changes: 3 additions & 4 deletions src/components/PositionDetails/SinglePositionInfo/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ export const useStyles = makeStyles()((theme: Theme) => ({
}
},
arrowIcon: {
width: 22,
width: 32,
marginRight: 8,
marginLeft: 8,
height: 22,
height: 32,
borderRadius: '100%',
padding: 4,

Expand All @@ -36,8 +36,7 @@ export const useStyles = makeStyles()((theme: Theme) => ({
},
'&:hover': {
cursor: 'pointer',
background: 'rgba(255, 255, 255, 0.15)',
filter: 'brightness(1.2)',
filter: 'brightness(2)',
'@media (hover: none)': {
filter: 'none'
}
Expand Down
4 changes: 3 additions & 1 deletion src/static/icons.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import copyAddress from './svg/copy-address.svg'
import emptyIcon from './svg/empty.svg'
import plusIcon from './svg/plus.svg'
import horizontalSwapIcon from './svg/horizontalSwapArrows.svg'
import swapListIcon from './svg/swap-list.svg'

const icons: { [key: string]: string } = {
clear: clearIcon,
Expand Down Expand Up @@ -59,7 +60,8 @@ const icons: { [key: string]: string } = {
copyAddress: copyAddress,
empty: emptyIcon,
plusIcon: plusIcon,
horizontalSwapIcon: horizontalSwapIcon
horizontalSwapIcon: horizontalSwapIcon,
swapListIcon: swapListIcon
}

export default icons
3 changes: 2 additions & 1 deletion src/store/consts/static.ts
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,8 @@ export const EMPTY_POSITION: Position = {
feeGrowthInsideY: 0n,
lastBlockNumber: 0n,
tokensOwedX: 0n,
tokensOwedY: 0n
tokensOwedY: 0n,
createdAt: 0n
}

export const POSITIONS_PER_QUERY =
Expand Down
2 changes: 0 additions & 2 deletions src/store/sagas/pools.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ export function* fetchPoolsDataForList(action: PayloadAction<ListPoolsRequest>)
yield* put(actions.addTokens(unknownTokensData))
yield* put(actions.updateTokenBalances(knownTokenBalances))

console.log(yield* select(tokens))

yield* put(actions.addPoolsForList({ data: pools, listType: action.payload.listType }))
}

Expand Down
2 changes: 0 additions & 2 deletions src/store/sagas/positions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,6 @@ export function* handleGetPositionsListPage(
}

if (!length || refresh) {
console.log('call', index)
const result = yield* call(
[invariant, invariant.getPositions],
walletAddress,
Expand Down Expand Up @@ -681,7 +680,6 @@ export function* handleGetPositionsListPage(

if (!isPageLoaded || refresh) {
if (length && !refresh) {
console.log('call', index)
const result = yield* call(
[invariant, invariant.getPositions],
walletAddress,
Expand Down
2 changes: 0 additions & 2 deletions src/store/selectors/positions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,8 @@ export const positionsWithPoolsData = createSelector(
const tokenY = tokens.find(token => token.assetAddress === position.poolKey.tokenY)

if (!tokenX) {
console.log(`Token ${position.poolKey.tokenX} not found for position`)
continue
} else if (!tokenY) {
console.log(`Token ${position.poolKey.tokenY} not found for position`)
continue
}

Expand Down
Loading