Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @intx4!
I'd like to propose the following changes to your Arkworks PR. The first one concerns the sample size in the benches. I've noticed that it's set to 10 by default. I assume you chose this value due to how slow verification is. However, the sample size for tree creation and (multi-)path proving can be increased by an order of magnitude, and every bench will take roughly the same time to execute.
The second change is refactoring the function
prefix_encode_path
using chained iterators. This approach is a bit more readable and even slightly more efficient. For reference, I get the following benches for the original implementation on my ThinkPad 14s machine:When using iterators, the performance seems to improve slightly: