Use OIC instead of Python-Jose #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sph-floatingpoint
approved these changes
May 21, 2024
Natim
reviewed
May 28, 2024
Natim
reviewed
May 28, 2024
This was referenced May 28, 2024
Co-authored-by: Rémy HUBSCHER <[email protected]>
Co-authored-by: Rémy HUBSCHER <[email protected]>
|
@robert-mings for visibility 👀 |
|
Introducing a dependency on OIC would cause a pretty significant explosion in transitive dependencies of this package. https://github.com/CZ-NIC/pyoidc/blob/master/setup.py#L86-L95 And it seems like overkill to bring in a "complete OpenID Connect implementation" just for the couple of JWK related functions actually used. PyJWT as implemented in #49 in contrast only really depends on the standard library and the well maintained and very popular cryptography package. |
|
Robert is off until June 24th, let's wait for his return to see if we can cut a release. |
jordan-chalupka
approved these changes
Jul 9, 2024
|
Thanks for the willingness to contribute @keaton185! We've moved ahead with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This package indirectly uses python-jose, which is affected by: GHSA-cjwg-qfpm-7377 which additionally seems to be abandoned by it's maintainers.
Move this package to use OIC to generate the JWK instead.