Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reconbatchid : Ignore unknown fields - SDK will ignore any unknown fields going forward #24

Merged
merged 4 commits into from
Sep 23, 2020

Conversation

abisalehalliprasan
Copy link
Collaborator

@abisalehalliprasan abisalehalliprasan commented Sep 9, 2020

Issue :
Developer getting error in sandbox - "Property name: [reconBatchID] is not a valid field for: [QuickBooksOnline\Payments\Modules\Context]. Please check your keys."

Referenced Issue Number:
#23

Fix Provided:

  • Added fields to src/Modules/Context.php:
    $reconBatchID;
    $paymentGroupingCode;
    $txnAuthorizationStamp;
    $paymentStatus;
    $merchantAccountNumber;
    $clientTransID;
    
  • SDK will be ignoring any uknown fields acorss all the Modules

Previous PR's considered :
#19
#22

Copy link
Contributor

@bsivalingam bsivalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. One suggestion though, for the sake of posterity can you please add description or make the commit message more descriptive to communicate why the change was made? Thanks!

@abisalehalliprasan abisalehalliprasan changed the title Feature/reconbatchid : Ignore unknown fields Feature/reconbatchid : Ignore unknown fields - SDK will ignore any unknown fields going forward Sep 23, 2020
@abisalehalliprasan abisalehalliprasan merged commit 77fe1c6 into master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants