-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue when connection is already in use. #20
Labels
enhancement
New feature or request
hammock
Channel your inner Rich Hickey
help wanted
Extra attention is needed
Comments
lispyclouds
added
enhancement
New feature or request
help wanted
Extra attention is needed
labels
Feb 4, 2020
TimoKramer
added a commit
to TimoKramer/bob
that referenced
this issue
Mar 17, 2020
- Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 - Refers bob-cd#20 into-docker/clj-docker-client#20 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Problem when multiple connections on socket occur still persists. Currently it is solved by using a simple patch in the clj-docker-lib that is in use. There a new connection is made everytime invoke is called. That disobeys settings made by the user and connects bulleaded to the local socket on /var/run/docker.sock. Squashed commit of the following: commit e6b5a8bad70bbe331dcebbf1cc4fa053bbc6167e Author: Timo Kramer <[email protected]> Date: Tue Mar 17 20:36:36 2020 +0100 using patched docker-lib to solve socket-problem commit 68b967459f9100f022b924cc5242dce09280c7d9 Author: Timo Kramer <[email protected]> Date: Tue Mar 17 15:57:32 2020 +0100 Revert "trying different things to solve socket problems" This reverts commit 57a335e. commit 57a335e Author: Timo Kramer <[email protected]> Date: Sun Mar 8 15:36:52 2020 +0100 trying different things to solve socket problems commit 21ad5f9 Author: Timo Kramer <[email protected]> Date: Fri Mar 6 13:15:51 2020 +0100 Upgraded clj-docker-client to 0.5.1 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Still there is a multiplex-problem when pulling multiple images. Squashed commit of the following: commit 64b6a32 Author: Timo Kramer <[email protected]> Date: Thu Mar 5 20:23:18 2020 +0100 improved some tests commit 554fa11 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:06:08 2020 +0100 the errors were not printed correctly commit 0915bfe Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:05:45 2020 +0100 extra connection for a pull because experiencing Socket problems commit ab297d4 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 01:02:04 2020 +0100 less delay because pipeline is passed and cannot be stopped commit a6c5c3a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 23:32:13 2020 +0100 logging was not working because of special chars commit 5fd3b69 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 14:15:12 2020 +0100 TODO was superfluous commit 47fc68a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:24:55 2020 +0100 refactored run to start-container because more accurate commit 04d51c0 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:14:33 2020 +0100 cider-formatting commit 50ea2fc Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:11:08 2020 +0100 refactored function build to create-container because that is more accurate commit aec1d81 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 11:34:15 2020 +0100 comment corrected commit f7eb578 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 10:58:07 2020 +0100 stream to artifact-store works now commit 509cbc9 Author: Timo Kramer <[email protected]> Date: Fri Feb 28 18:32:24 2020 +0100 bootstrap_wendy.sh fails on extracting the tar commit aed0816 Merge: 05e1d75 afa375b Author: Timo Kramer <[email protected]> Date: Fri Feb 28 14:50:09 2020 +0100 Merge remote-tracking branch 'bob/master' into bob-cd#68-upgrade-docker-client commit 05e1d75 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 16:24:10 2020 +0100 refactored commit e939327 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 10:15:39 2020 +0100 mistake in health-check was always returning unhealthy or errored out on connection issue commit f9577df Author: Timo Kramer <[email protected]> Date: Tue Feb 25 15:38:05 2020 +0100 fixed malformed return of commit-image function commit 9d05e0d Author: Timo Kramer <[email protected]> Date: Tue Feb 25 12:41:14 2020 +0100 took functions to format CMD and ENV for passing to daemon commit 1217e31 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 18:50:08 2020 +0100 TODO added commit 5c33c05 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 14:05:13 2020 +0100 log-streaming implemented commit bef9118 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:17 2020 +0100 updated docker-client commit 1bfddf1 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:03 2020 +0100 timeouts added for docker connection commit 180262a Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:25:42 2020 +0100 bug filed for clj-docker on timeout on putcontainerarchive commit 4298a4f Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:36 2020 +0100 garbage collection repaired commit 2036b96 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:12 2020 +0100 refactored execution internals commit 5b3b25b Author: Timo Kramer <[email protected]> Date: Tue Feb 18 14:06:07 2020 +0100 fixed some tests commit a550949 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 11:36:02 2020 +0100 pipeline internals adapted commit fbf8a98 Author: Timo Kramer <[email protected]> Date: Mon Feb 17 17:55:39 2020 +0100 refactored commit-image into execution/internals and adapted pipeline/internals next-step to new clj-docker-client commit e7084b3 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:21:15 2020 +0100 failing test; dont know how to mock file commit 44acdb9 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:20:20 2020 +0100 made commit a state commit d9e003f Author: Timo Kramer <[email protected]> Date: Fri Feb 14 16:06:23 2020 +0100 resource internals adapted commit 74baf38 Author: Timo Kramer <[email protected]> Date: Mon Feb 10 16:01:08 2020 +0100 artifact/core adapted commit 6b81cce Author: Timo Kramer <[email protected]> Date: Mon Feb 10 12:44:52 2020 +0100 health check adapted commit 5c9f70b Author: Timo Kramer <[email protected]> Date: Thu Feb 6 17:50:31 2020 +0100 run function using new clj-docker commit 448df78 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:56:54 2020 +0100 improved build to use failjure return commit 1f89b75 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:22:16 2020 +0100 status-of function now using new clj-docker lib commit 8de9273 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 15:06:03 2020 +0100 validation for image name improved and container build implemented commit b8eda9d Author: Timo Kramer <[email protected]> Date: Tue Feb 4 15:01:02 2020 +0100 log-and-fail to avoid repetition commit d38ff6c Author: Timo Kramer <[email protected]> Date: Sun Feb 2 18:36:38 2020 +0100 pull image function refactored commit c7a4c66 Author: Timo Kramer <[email protected]> Date: Thu Jan 30 16:05:27 2020 +0100 switched to states commit 6d51bd2 Author: Timo Kramer <[email protected]> Date: Wed Jan 29 13:16:42 2020 +0100 kill-container commit d944ebc Author: Timo Kramer <[email protected]> Date: Wed Jan 29 10:51:55 2020 +0100 first function transitioned to clj-docker 0.4.0
TimoKramer
added a commit
to TimoKramer/bob
that referenced
this issue
Mar 17, 2020
- Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 - Refers bob-cd#20 into-docker/clj-docker-client#20 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Problem when multiple connections on socket occur still persists. Currently it is solved by using a simple patch in the clj-docker-lib that is in use. There a new connection is made everytime invoke is called. That disobeys settings made by the user and connects bulleaded to the local socket on /var/run/docker.sock. Squashed commit of the following: commit e6b5a8bad70bbe331dcebbf1cc4fa053bbc6167e Author: Timo Kramer <[email protected]> Date: Tue Mar 17 20:36:36 2020 +0100 using patched docker-lib to solve socket-problem commit 68b967459f9100f022b924cc5242dce09280c7d9 Author: Timo Kramer <[email protected]> Date: Tue Mar 17 15:57:32 2020 +0100 Revert "trying different things to solve socket problems" This reverts commit 57a335e. commit 57a335e Author: Timo Kramer <[email protected]> Date: Sun Mar 8 15:36:52 2020 +0100 trying different things to solve socket problems commit 21ad5f9 Author: Timo Kramer <[email protected]> Date: Fri Mar 6 13:15:51 2020 +0100 Upgraded clj-docker-client to 0.5.1 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Still there is a multiplex-problem when pulling multiple images. Squashed commit of the following: commit 64b6a32 Author: Timo Kramer <[email protected]> Date: Thu Mar 5 20:23:18 2020 +0100 improved some tests commit 554fa11 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:06:08 2020 +0100 the errors were not printed correctly commit 0915bfe Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:05:45 2020 +0100 extra connection for a pull because experiencing Socket problems commit ab297d4 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 01:02:04 2020 +0100 less delay because pipeline is passed and cannot be stopped commit a6c5c3a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 23:32:13 2020 +0100 logging was not working because of special chars commit 5fd3b69 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 14:15:12 2020 +0100 TODO was superfluous commit 47fc68a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:24:55 2020 +0100 refactored run to start-container because more accurate commit 04d51c0 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:14:33 2020 +0100 cider-formatting commit 50ea2fc Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:11:08 2020 +0100 refactored function build to create-container because that is more accurate commit aec1d81 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 11:34:15 2020 +0100 comment corrected commit f7eb578 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 10:58:07 2020 +0100 stream to artifact-store works now commit 509cbc9 Author: Timo Kramer <[email protected]> Date: Fri Feb 28 18:32:24 2020 +0100 bootstrap_wendy.sh fails on extracting the tar commit aed0816 Merge: 05e1d75 afa375b Author: Timo Kramer <[email protected]> Date: Fri Feb 28 14:50:09 2020 +0100 Merge remote-tracking branch 'bob/master' into bob-cd#68-upgrade-docker-client commit 05e1d75 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 16:24:10 2020 +0100 refactored commit e939327 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 10:15:39 2020 +0100 mistake in health-check was always returning unhealthy or errored out on connection issue commit f9577df Author: Timo Kramer <[email protected]> Date: Tue Feb 25 15:38:05 2020 +0100 fixed malformed return of commit-image function commit 9d05e0d Author: Timo Kramer <[email protected]> Date: Tue Feb 25 12:41:14 2020 +0100 took functions to format CMD and ENV for passing to daemon commit 1217e31 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 18:50:08 2020 +0100 TODO added commit 5c33c05 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 14:05:13 2020 +0100 log-streaming implemented commit bef9118 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:17 2020 +0100 updated docker-client commit 1bfddf1 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:03 2020 +0100 timeouts added for docker connection commit 180262a Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:25:42 2020 +0100 bug filed for clj-docker on timeout on putcontainerarchive commit 4298a4f Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:36 2020 +0100 garbage collection repaired commit 2036b96 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:12 2020 +0100 refactored execution internals commit 5b3b25b Author: Timo Kramer <[email protected]> Date: Tue Feb 18 14:06:07 2020 +0100 fixed some tests commit a550949 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 11:36:02 2020 +0100 pipeline internals adapted commit fbf8a98 Author: Timo Kramer <[email protected]> Date: Mon Feb 17 17:55:39 2020 +0100 refactored commit-image into execution/internals and adapted pipeline/internals next-step to new clj-docker-client commit e7084b3 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:21:15 2020 +0100 failing test; dont know how to mock file commit 44acdb9 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:20:20 2020 +0100 made commit a state commit d9e003f Author: Timo Kramer <[email protected]> Date: Fri Feb 14 16:06:23 2020 +0100 resource internals adapted commit 74baf38 Author: Timo Kramer <[email protected]> Date: Mon Feb 10 16:01:08 2020 +0100 artifact/core adapted commit 6b81cce Author: Timo Kramer <[email protected]> Date: Mon Feb 10 12:44:52 2020 +0100 health check adapted commit 5c9f70b Author: Timo Kramer <[email protected]> Date: Thu Feb 6 17:50:31 2020 +0100 run function using new clj-docker commit 448df78 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:56:54 2020 +0100 improved build to use failjure return commit 1f89b75 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:22:16 2020 +0100 status-of function now using new clj-docker lib commit 8de9273 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 15:06:03 2020 +0100 validation for image name improved and container build implemented commit b8eda9d Author: Timo Kramer <[email protected]> Date: Tue Feb 4 15:01:02 2020 +0100 log-and-fail to avoid repetition commit d38ff6c Author: Timo Kramer <[email protected]> Date: Sun Feb 2 18:36:38 2020 +0100 pull image function refactored commit c7a4c66 Author: Timo Kramer <[email protected]> Date: Thu Jan 30 16:05:27 2020 +0100 switched to states commit 6d51bd2 Author: Timo Kramer <[email protected]> Date: Wed Jan 29 13:16:42 2020 +0100 kill-container commit d944ebc Author: Timo Kramer <[email protected]> Date: Wed Jan 29 10:51:55 2020 +0100 first function transitioned to clj-docker 0.4.0
TimoKramer
added a commit
to TimoKramer/bob
that referenced
this issue
Mar 17, 2020
- Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 - Refers bob-cd#20 into-docker/clj-docker-client#20 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Problem when multiple connections on socket occur still persists. Currently it is solved by using a simple patch in the clj-docker-lib that is in use. There a new connection is made everytime invoke is called. That disobeys settings made by the user and connects bulleaded to the local socket on /var/run/docker.sock. Squashed commit of the following: commit e6b5a8bad70bbe331dcebbf1cc4fa053bbc6167e Author: Timo Kramer <[email protected]> Date: Tue Mar 17 20:36:36 2020 +0100 using patched docker-lib to solve socket-problem commit 68b967459f9100f022b924cc5242dce09280c7d9 Author: Timo Kramer <[email protected]> Date: Tue Mar 17 15:57:32 2020 +0100 Revert "trying different things to solve socket problems" This reverts commit 57a335e. commit 57a335e Author: Timo Kramer <[email protected]> Date: Sun Mar 8 15:36:52 2020 +0100 trying different things to solve socket problems commit 21ad5f9 Author: Timo Kramer <[email protected]> Date: Fri Mar 6 13:15:51 2020 +0100 Upgraded clj-docker-client to 0.5.1 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Still there is a multiplex-problem when pulling multiple images. Squashed commit of the following: commit 64b6a32 Author: Timo Kramer <[email protected]> Date: Thu Mar 5 20:23:18 2020 +0100 improved some tests commit 554fa11 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:06:08 2020 +0100 the errors were not printed correctly commit 0915bfe Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:05:45 2020 +0100 extra connection for a pull because experiencing Socket problems commit ab297d4 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 01:02:04 2020 +0100 less delay because pipeline is passed and cannot be stopped commit a6c5c3a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 23:32:13 2020 +0100 logging was not working because of special chars commit 5fd3b69 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 14:15:12 2020 +0100 TODO was superfluous commit 47fc68a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:24:55 2020 +0100 refactored run to start-container because more accurate commit 04d51c0 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:14:33 2020 +0100 cider-formatting commit 50ea2fc Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:11:08 2020 +0100 refactored function build to create-container because that is more accurate commit aec1d81 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 11:34:15 2020 +0100 comment corrected commit f7eb578 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 10:58:07 2020 +0100 stream to artifact-store works now commit 509cbc9 Author: Timo Kramer <[email protected]> Date: Fri Feb 28 18:32:24 2020 +0100 bootstrap_wendy.sh fails on extracting the tar commit aed0816 Merge: 05e1d75 afa375b Author: Timo Kramer <[email protected]> Date: Fri Feb 28 14:50:09 2020 +0100 Merge remote-tracking branch 'bob/master' into bob-cd#68-upgrade-docker-client commit 05e1d75 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 16:24:10 2020 +0100 refactored commit e939327 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 10:15:39 2020 +0100 mistake in health-check was always returning unhealthy or errored out on connection issue commit f9577df Author: Timo Kramer <[email protected]> Date: Tue Feb 25 15:38:05 2020 +0100 fixed malformed return of commit-image function commit 9d05e0d Author: Timo Kramer <[email protected]> Date: Tue Feb 25 12:41:14 2020 +0100 took functions to format CMD and ENV for passing to daemon commit 1217e31 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 18:50:08 2020 +0100 TODO added commit 5c33c05 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 14:05:13 2020 +0100 log-streaming implemented commit bef9118 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:17 2020 +0100 updated docker-client commit 1bfddf1 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:03 2020 +0100 timeouts added for docker connection commit 180262a Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:25:42 2020 +0100 bug filed for clj-docker on timeout on putcontainerarchive commit 4298a4f Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:36 2020 +0100 garbage collection repaired commit 2036b96 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:12 2020 +0100 refactored execution internals commit 5b3b25b Author: Timo Kramer <[email protected]> Date: Tue Feb 18 14:06:07 2020 +0100 fixed some tests commit a550949 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 11:36:02 2020 +0100 pipeline internals adapted commit fbf8a98 Author: Timo Kramer <[email protected]> Date: Mon Feb 17 17:55:39 2020 +0100 refactored commit-image into execution/internals and adapted pipeline/internals next-step to new clj-docker-client commit e7084b3 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:21:15 2020 +0100 failing test; dont know how to mock file commit 44acdb9 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:20:20 2020 +0100 made commit a state commit d9e003f Author: Timo Kramer <[email protected]> Date: Fri Feb 14 16:06:23 2020 +0100 resource internals adapted commit 74baf38 Author: Timo Kramer <[email protected]> Date: Mon Feb 10 16:01:08 2020 +0100 artifact/core adapted commit 6b81cce Author: Timo Kramer <[email protected]> Date: Mon Feb 10 12:44:52 2020 +0100 health check adapted commit 5c9f70b Author: Timo Kramer <[email protected]> Date: Thu Feb 6 17:50:31 2020 +0100 run function using new clj-docker commit 448df78 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:56:54 2020 +0100 improved build to use failjure return commit 1f89b75 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:22:16 2020 +0100 status-of function now using new clj-docker lib commit 8de9273 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 15:06:03 2020 +0100 validation for image name improved and container build implemented commit b8eda9d Author: Timo Kramer <[email protected]> Date: Tue Feb 4 15:01:02 2020 +0100 log-and-fail to avoid repetition commit d38ff6c Author: Timo Kramer <[email protected]> Date: Sun Feb 2 18:36:38 2020 +0100 pull image function refactored commit c7a4c66 Author: Timo Kramer <[email protected]> Date: Thu Jan 30 16:05:27 2020 +0100 switched to states commit 6d51bd2 Author: Timo Kramer <[email protected]> Date: Wed Jan 29 13:16:42 2020 +0100 kill-container commit d944ebc Author: Timo Kramer <[email protected]> Date: Wed Jan 29 10:51:55 2020 +0100 first function transitioned to clj-docker 0.4.0
TimoKramer
added a commit
to TimoKramer/clj-docker-client
that referenced
this issue
Mar 22, 2020
Since we had problems using this lib in bob, we decided to change the behaviour to connect everytime you call invoke. The connect function is now deprecated and only returns a map to avoid breaking the api. You still are able to use client like before but it is discouraged now to use connect and only using invoke is also sufficient. Refers into-docker#20
TimoKramer
added a commit
to TimoKramer/clj-docker-client
that referenced
this issue
Mar 22, 2020
Since we had problems using this lib in bob, we decided to change the behaviour to connect everytime you call invoke. The connect function is now deprecated and only returns a map to avoid breaking the api. You still are able to use client like before but it is discouraged now to use connect and only using invoke is also sufficient. Refers into-docker#20
TimoKramer
added a commit
to TimoKramer/clj-docker-client
that referenced
this issue
Mar 22, 2020
Since we had problems using this lib in bob, we decided to change the behaviour to connect everytime you call invoke. The connect function is now deprecated and only returns a map to avoid breaking the api. You still are able to use client like before but it is discouraged now to use connect and only using invoke is also sufficient. I moved the connect-function to the requests namespace because it is not part of the official api but is used with the fetch-function and therefore should reside with it. The documentation is changed accordingly and fetch needs to call the for now unofficial function connect*. Refers into-docker#20
TimoKramer
added a commit
to TimoKramer/clj-docker-client
that referenced
this issue
Mar 22, 2020
Since we had problems using this lib in bob, we decided to change the behaviour to connect everytime you call invoke. The connect function is now deprecated and only returns a map to avoid breaking the api. You still are able to use client like before but it is discouraged now to use connect and only using invoke is also sufficient. I moved the connect-function to the requests namespace because it is not part of the official api but is used with the fetch-function and therefore should reside with it. The documentation is changed accordingly and fetch needs to call the for now unofficial function connect*. Refers into-docker#20
TimoKramer
added a commit
to TimoKramer/clj-docker-client
that referenced
this issue
Mar 22, 2020
Since we had problems using this lib in bob, we decided to change the behaviour to connect everytime you call invoke. The connect function is now deprecated and only returns a map to avoid breaking the api. You still are able to use client like before but it is discouraged now to use connect and only using invoke is also sufficient. I moved the connect-function to the requests namespace because it is not part of the official api but is used with the fetch-function and therefore should reside with it. The panic! function has to be in the requests namespace as well because otherwise we would have a cyclic dependency. The documentation is changed accordingly and fetch needs to call the for now unofficial function connect*. Refers into-docker#20
TimoKramer
added a commit
to TimoKramer/bob
that referenced
this issue
Mar 23, 2020
- Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 - Refers bob-cd#20 into-docker/clj-docker-client#20 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. A new connection is made everytime invoke is called with the new clj-docker-client. The url bob connects to is now configured via env-var. That solves the problem we had with the former version of the client-lib. Documentation shows handling of variables set globally. Squashed commit of the following: commit e6b5a8bad70bbe331dcebbf1cc4fa053bbc6167e Author: Timo Kramer <[email protected]> Date: Tue Mar 17 20:36:36 2020 +0100 using patched docker-lib to solve socket-problem commit 68b967459f9100f022b924cc5242dce09280c7d9 Author: Timo Kramer <[email protected]> Date: Tue Mar 17 15:57:32 2020 +0100 Revert "trying different things to solve socket problems" This reverts commit 57a335e. commit 57a335e Author: Timo Kramer <[email protected]> Date: Sun Mar 8 15:36:52 2020 +0100 trying different things to solve socket problems commit 21ad5f9 Author: Timo Kramer <[email protected]> Date: Fri Mar 6 13:15:51 2020 +0100 Upgraded clj-docker-client to 0.5.1 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Still there is a multiplex-problem when pulling multiple images. Squashed commit of the following: commit 64b6a32 Author: Timo Kramer <[email protected]> Date: Thu Mar 5 20:23:18 2020 +0100 improved some tests commit 554fa11 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:06:08 2020 +0100 the errors were not printed correctly commit 0915bfe Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:05:45 2020 +0100 extra connection for a pull because experiencing Socket problems commit ab297d4 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 01:02:04 2020 +0100 less delay because pipeline is passed and cannot be stopped commit a6c5c3a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 23:32:13 2020 +0100 logging was not working because of special chars commit 5fd3b69 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 14:15:12 2020 +0100 TODO was superfluous commit 47fc68a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:24:55 2020 +0100 refactored run to start-container because more accurate commit 04d51c0 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:14:33 2020 +0100 cider-formatting commit 50ea2fc Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:11:08 2020 +0100 refactored function build to create-container because that is more accurate commit aec1d81 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 11:34:15 2020 +0100 comment corrected commit f7eb578 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 10:58:07 2020 +0100 stream to artifact-store works now commit 509cbc9 Author: Timo Kramer <[email protected]> Date: Fri Feb 28 18:32:24 2020 +0100 bootstrap_wendy.sh fails on extracting the tar commit aed0816 Merge: 05e1d75 afa375b Author: Timo Kramer <[email protected]> Date: Fri Feb 28 14:50:09 2020 +0100 Merge remote-tracking branch 'bob/master' into bob-cd#68-upgrade-docker-client commit 05e1d75 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 16:24:10 2020 +0100 refactored commit e939327 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 10:15:39 2020 +0100 mistake in health-check was always returning unhealthy or errored out on connection issue commit f9577df Author: Timo Kramer <[email protected]> Date: Tue Feb 25 15:38:05 2020 +0100 fixed malformed return of commit-image function commit 9d05e0d Author: Timo Kramer <[email protected]> Date: Tue Feb 25 12:41:14 2020 +0100 took functions to format CMD and ENV for passing to daemon commit 1217e31 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 18:50:08 2020 +0100 TODO added commit 5c33c05 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 14:05:13 2020 +0100 log-streaming implemented commit bef9118 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:17 2020 +0100 updated docker-client commit 1bfddf1 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:03 2020 +0100 timeouts added for docker connection commit 180262a Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:25:42 2020 +0100 bug filed for clj-docker on timeout on putcontainerarchive commit 4298a4f Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:36 2020 +0100 garbage collection repaired commit 2036b96 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:12 2020 +0100 refactored execution internals commit 5b3b25b Author: Timo Kramer <[email protected]> Date: Tue Feb 18 14:06:07 2020 +0100 fixed some tests commit a550949 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 11:36:02 2020 +0100 pipeline internals adapted commit fbf8a98 Author: Timo Kramer <[email protected]> Date: Mon Feb 17 17:55:39 2020 +0100 refactored commit-image into execution/internals and adapted pipeline/internals next-step to new clj-docker-client commit e7084b3 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:21:15 2020 +0100 failing test; dont know how to mock file commit 44acdb9 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:20:20 2020 +0100 made commit a state commit d9e003f Author: Timo Kramer <[email protected]> Date: Fri Feb 14 16:06:23 2020 +0100 resource internals adapted commit 74baf38 Author: Timo Kramer <[email protected]> Date: Mon Feb 10 16:01:08 2020 +0100 artifact/core adapted commit 6b81cce Author: Timo Kramer <[email protected]> Date: Mon Feb 10 12:44:52 2020 +0100 health check adapted commit 5c9f70b Author: Timo Kramer <[email protected]> Date: Thu Feb 6 17:50:31 2020 +0100 run function using new clj-docker commit 448df78 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:56:54 2020 +0100 improved build to use failjure return commit 1f89b75 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:22:16 2020 +0100 status-of function now using new clj-docker lib commit 8de9273 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 15:06:03 2020 +0100 validation for image name improved and container build implemented commit b8eda9d Author: Timo Kramer <[email protected]> Date: Tue Feb 4 15:01:02 2020 +0100 log-and-fail to avoid repetition commit d38ff6c Author: Timo Kramer <[email protected]> Date: Sun Feb 2 18:36:38 2020 +0100 pull image function refactored commit c7a4c66 Author: Timo Kramer <[email protected]> Date: Thu Jan 30 16:05:27 2020 +0100 switched to states commit 6d51bd2 Author: Timo Kramer <[email protected]> Date: Wed Jan 29 13:16:42 2020 +0100 kill-container commit d944ebc Author: Timo Kramer <[email protected]> Date: Wed Jan 29 10:51:55 2020 +0100 first function transitioned to clj-docker 0.4.0
TimoKramer
added a commit
to TimoKramer/bob
that referenced
this issue
Mar 23, 2020
- Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 - Closes bob-cd#56 - Refers bob-cd#20 into-docker/clj-docker-client#20 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. A new connection is made everytime invoke is called with the new clj-docker-client. The url bob connects to is now configured via env-var. That solves the problem we had with the former version of the client-lib. Documentation shows handling of variables set globally. Squashed commit of the following: commit e6b5a8bad70bbe331dcebbf1cc4fa053bbc6167e Author: Timo Kramer <[email protected]> Date: Tue Mar 17 20:36:36 2020 +0100 using patched docker-lib to solve socket-problem commit 68b967459f9100f022b924cc5242dce09280c7d9 Author: Timo Kramer <[email protected]> Date: Tue Mar 17 15:57:32 2020 +0100 Revert "trying different things to solve socket problems" This reverts commit 57a335e. commit 57a335e Author: Timo Kramer <[email protected]> Date: Sun Mar 8 15:36:52 2020 +0100 trying different things to solve socket problems commit 21ad5f9 Author: Timo Kramer <[email protected]> Date: Fri Mar 6 13:15:51 2020 +0100 Upgraded clj-docker-client to 0.5.1 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Still there is a multiplex-problem when pulling multiple images. Squashed commit of the following: commit 64b6a32 Author: Timo Kramer <[email protected]> Date: Thu Mar 5 20:23:18 2020 +0100 improved some tests commit 554fa11 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:06:08 2020 +0100 the errors were not printed correctly commit 0915bfe Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:05:45 2020 +0100 extra connection for a pull because experiencing Socket problems commit ab297d4 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 01:02:04 2020 +0100 less delay because pipeline is passed and cannot be stopped commit a6c5c3a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 23:32:13 2020 +0100 logging was not working because of special chars commit 5fd3b69 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 14:15:12 2020 +0100 TODO was superfluous commit 47fc68a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:24:55 2020 +0100 refactored run to start-container because more accurate commit 04d51c0 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:14:33 2020 +0100 cider-formatting commit 50ea2fc Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:11:08 2020 +0100 refactored function build to create-container because that is more accurate commit aec1d81 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 11:34:15 2020 +0100 comment corrected commit f7eb578 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 10:58:07 2020 +0100 stream to artifact-store works now commit 509cbc9 Author: Timo Kramer <[email protected]> Date: Fri Feb 28 18:32:24 2020 +0100 bootstrap_wendy.sh fails on extracting the tar commit aed0816 Merge: 05e1d75 afa375b Author: Timo Kramer <[email protected]> Date: Fri Feb 28 14:50:09 2020 +0100 Merge remote-tracking branch 'bob/master' into bob-cd#68-upgrade-docker-client commit 05e1d75 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 16:24:10 2020 +0100 refactored commit e939327 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 10:15:39 2020 +0100 mistake in health-check was always returning unhealthy or errored out on connection issue commit f9577df Author: Timo Kramer <[email protected]> Date: Tue Feb 25 15:38:05 2020 +0100 fixed malformed return of commit-image function commit 9d05e0d Author: Timo Kramer <[email protected]> Date: Tue Feb 25 12:41:14 2020 +0100 took functions to format CMD and ENV for passing to daemon commit 1217e31 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 18:50:08 2020 +0100 TODO added commit 5c33c05 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 14:05:13 2020 +0100 log-streaming implemented commit bef9118 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:17 2020 +0100 updated docker-client commit 1bfddf1 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:03 2020 +0100 timeouts added for docker connection commit 180262a Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:25:42 2020 +0100 bug filed for clj-docker on timeout on putcontainerarchive commit 4298a4f Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:36 2020 +0100 garbage collection repaired commit 2036b96 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:12 2020 +0100 refactored execution internals commit 5b3b25b Author: Timo Kramer <[email protected]> Date: Tue Feb 18 14:06:07 2020 +0100 fixed some tests commit a550949 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 11:36:02 2020 +0100 pipeline internals adapted commit fbf8a98 Author: Timo Kramer <[email protected]> Date: Mon Feb 17 17:55:39 2020 +0100 refactored commit-image into execution/internals and adapted pipeline/internals next-step to new clj-docker-client commit e7084b3 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:21:15 2020 +0100 failing test; dont know how to mock file commit 44acdb9 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:20:20 2020 +0100 made commit a state commit d9e003f Author: Timo Kramer <[email protected]> Date: Fri Feb 14 16:06:23 2020 +0100 resource internals adapted commit 74baf38 Author: Timo Kramer <[email protected]> Date: Mon Feb 10 16:01:08 2020 +0100 artifact/core adapted commit 6b81cce Author: Timo Kramer <[email protected]> Date: Mon Feb 10 12:44:52 2020 +0100 health check adapted commit 5c9f70b Author: Timo Kramer <[email protected]> Date: Thu Feb 6 17:50:31 2020 +0100 run function using new clj-docker commit 448df78 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:56:54 2020 +0100 improved build to use failjure return commit 1f89b75 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:22:16 2020 +0100 status-of function now using new clj-docker lib commit 8de9273 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 15:06:03 2020 +0100 validation for image name improved and container build implemented commit b8eda9d Author: Timo Kramer <[email protected]> Date: Tue Feb 4 15:01:02 2020 +0100 log-and-fail to avoid repetition commit d38ff6c Author: Timo Kramer <[email protected]> Date: Sun Feb 2 18:36:38 2020 +0100 pull image function refactored commit c7a4c66 Author: Timo Kramer <[email protected]> Date: Thu Jan 30 16:05:27 2020 +0100 switched to states commit 6d51bd2 Author: Timo Kramer <[email protected]> Date: Wed Jan 29 13:16:42 2020 +0100 kill-container commit d944ebc Author: Timo Kramer <[email protected]> Date: Wed Jan 29 10:51:55 2020 +0100 first function transitioned to clj-docker 0.4.0
TimoKramer
added a commit
to TimoKramer/bob
that referenced
this issue
Mar 23, 2020
- Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 - Closes bob-cd#56 - Refers bob-cd#20 into-docker/clj-docker-client#20 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. A new connection is made everytime invoke is called with the new clj-docker-client. That solves the problem we had with the former version of the client-lib. The url bob connects to is now configured via env-var. Documentation shows handling of variables set globally. Squashed commit of the following: commit e6b5a8bad70bbe331dcebbf1cc4fa053bbc6167e Author: Timo Kramer <[email protected]> Date: Tue Mar 17 20:36:36 2020 +0100 using patched docker-lib to solve socket-problem commit 68b967459f9100f022b924cc5242dce09280c7d9 Author: Timo Kramer <[email protected]> Date: Tue Mar 17 15:57:32 2020 +0100 Revert "trying different things to solve socket problems" This reverts commit 57a335e. commit 57a335e Author: Timo Kramer <[email protected]> Date: Sun Mar 8 15:36:52 2020 +0100 trying different things to solve socket problems commit 21ad5f9 Author: Timo Kramer <[email protected]> Date: Fri Mar 6 13:15:51 2020 +0100 Upgraded clj-docker-client to 0.5.1 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Still there is a multiplex-problem when pulling multiple images. Squashed commit of the following: commit 64b6a32 Author: Timo Kramer <[email protected]> Date: Thu Mar 5 20:23:18 2020 +0100 improved some tests commit 554fa11 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:06:08 2020 +0100 the errors were not printed correctly commit 0915bfe Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:05:45 2020 +0100 extra connection for a pull because experiencing Socket problems commit ab297d4 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 01:02:04 2020 +0100 less delay because pipeline is passed and cannot be stopped commit a6c5c3a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 23:32:13 2020 +0100 logging was not working because of special chars commit 5fd3b69 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 14:15:12 2020 +0100 TODO was superfluous commit 47fc68a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:24:55 2020 +0100 refactored run to start-container because more accurate commit 04d51c0 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:14:33 2020 +0100 cider-formatting commit 50ea2fc Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:11:08 2020 +0100 refactored function build to create-container because that is more accurate commit aec1d81 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 11:34:15 2020 +0100 comment corrected commit f7eb578 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 10:58:07 2020 +0100 stream to artifact-store works now commit 509cbc9 Author: Timo Kramer <[email protected]> Date: Fri Feb 28 18:32:24 2020 +0100 bootstrap_wendy.sh fails on extracting the tar commit aed0816 Merge: 05e1d75 afa375b Author: Timo Kramer <[email protected]> Date: Fri Feb 28 14:50:09 2020 +0100 Merge remote-tracking branch 'bob/master' into bob-cd#68-upgrade-docker-client commit 05e1d75 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 16:24:10 2020 +0100 refactored commit e939327 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 10:15:39 2020 +0100 mistake in health-check was always returning unhealthy or errored out on connection issue commit f9577df Author: Timo Kramer <[email protected]> Date: Tue Feb 25 15:38:05 2020 +0100 fixed malformed return of commit-image function commit 9d05e0d Author: Timo Kramer <[email protected]> Date: Tue Feb 25 12:41:14 2020 +0100 took functions to format CMD and ENV for passing to daemon commit 1217e31 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 18:50:08 2020 +0100 TODO added commit 5c33c05 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 14:05:13 2020 +0100 log-streaming implemented commit bef9118 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:17 2020 +0100 updated docker-client commit 1bfddf1 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:03 2020 +0100 timeouts added for docker connection commit 180262a Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:25:42 2020 +0100 bug filed for clj-docker on timeout on putcontainerarchive commit 4298a4f Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:36 2020 +0100 garbage collection repaired commit 2036b96 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:12 2020 +0100 refactored execution internals commit 5b3b25b Author: Timo Kramer <[email protected]> Date: Tue Feb 18 14:06:07 2020 +0100 fixed some tests commit a550949 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 11:36:02 2020 +0100 pipeline internals adapted commit fbf8a98 Author: Timo Kramer <[email protected]> Date: Mon Feb 17 17:55:39 2020 +0100 refactored commit-image into execution/internals and adapted pipeline/internals next-step to new clj-docker-client commit e7084b3 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:21:15 2020 +0100 failing test; dont know how to mock file commit 44acdb9 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:20:20 2020 +0100 made commit a state commit d9e003f Author: Timo Kramer <[email protected]> Date: Fri Feb 14 16:06:23 2020 +0100 resource internals adapted commit 74baf38 Author: Timo Kramer <[email protected]> Date: Mon Feb 10 16:01:08 2020 +0100 artifact/core adapted commit 6b81cce Author: Timo Kramer <[email protected]> Date: Mon Feb 10 12:44:52 2020 +0100 health check adapted commit 5c9f70b Author: Timo Kramer <[email protected]> Date: Thu Feb 6 17:50:31 2020 +0100 run function using new clj-docker commit 448df78 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:56:54 2020 +0100 improved build to use failjure return commit 1f89b75 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:22:16 2020 +0100 status-of function now using new clj-docker lib commit 8de9273 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 15:06:03 2020 +0100 validation for image name improved and container build implemented commit b8eda9d Author: Timo Kramer <[email protected]> Date: Tue Feb 4 15:01:02 2020 +0100 log-and-fail to avoid repetition commit d38ff6c Author: Timo Kramer <[email protected]> Date: Sun Feb 2 18:36:38 2020 +0100 pull image function refactored commit c7a4c66 Author: Timo Kramer <[email protected]> Date: Thu Jan 30 16:05:27 2020 +0100 switched to states commit 6d51bd2 Author: Timo Kramer <[email protected]> Date: Wed Jan 29 13:16:42 2020 +0100 kill-container commit d944ebc Author: Timo Kramer <[email protected]> Date: Wed Jan 29 10:51:55 2020 +0100 first function transitioned to clj-docker 0.4.0
TimoKramer
added a commit
to TimoKramer/bob
that referenced
this issue
Mar 23, 2020
- Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 - Closes bob-cd#56 - Refers bob-cd#20 into-docker/clj-docker-client#20 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. A new connection is made everytime invoke is called with the new clj-docker-client. That solves the problem we had with the former version of the client-lib. The url bob connects to is now configured via env-var. Documentation shows handling of variables set globally. Squashed commit of the following: commit e6b5a8bad70bbe331dcebbf1cc4fa053bbc6167e Author: Timo Kramer <[email protected]> Date: Tue Mar 17 20:36:36 2020 +0100 using patched docker-lib to solve socket-problem commit 68b967459f9100f022b924cc5242dce09280c7d9 Author: Timo Kramer <[email protected]> Date: Tue Mar 17 15:57:32 2020 +0100 Revert "trying different things to solve socket problems" This reverts commit 57a335e. commit 57a335e Author: Timo Kramer <[email protected]> Date: Sun Mar 8 15:36:52 2020 +0100 trying different things to solve socket problems commit 21ad5f9 Author: Timo Kramer <[email protected]> Date: Fri Mar 6 13:15:51 2020 +0100 Upgraded clj-docker-client to 0.5.1 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Still there is a multiplex-problem when pulling multiple images. Squashed commit of the following: commit 64b6a32 Author: Timo Kramer <[email protected]> Date: Thu Mar 5 20:23:18 2020 +0100 improved some tests commit 554fa11 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:06:08 2020 +0100 the errors were not printed correctly commit 0915bfe Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:05:45 2020 +0100 extra connection for a pull because experiencing Socket problems commit ab297d4 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 01:02:04 2020 +0100 less delay because pipeline is passed and cannot be stopped commit a6c5c3a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 23:32:13 2020 +0100 logging was not working because of special chars commit 5fd3b69 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 14:15:12 2020 +0100 TODO was superfluous commit 47fc68a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:24:55 2020 +0100 refactored run to start-container because more accurate commit 04d51c0 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:14:33 2020 +0100 cider-formatting commit 50ea2fc Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:11:08 2020 +0100 refactored function build to create-container because that is more accurate commit aec1d81 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 11:34:15 2020 +0100 comment corrected commit f7eb578 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 10:58:07 2020 +0100 stream to artifact-store works now commit 509cbc9 Author: Timo Kramer <[email protected]> Date: Fri Feb 28 18:32:24 2020 +0100 bootstrap_wendy.sh fails on extracting the tar commit aed0816 Merge: 05e1d75 afa375b Author: Timo Kramer <[email protected]> Date: Fri Feb 28 14:50:09 2020 +0100 Merge remote-tracking branch 'bob/master' into bob-cd#68-upgrade-docker-client commit 05e1d75 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 16:24:10 2020 +0100 refactored commit e939327 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 10:15:39 2020 +0100 mistake in health-check was always returning unhealthy or errored out on connection issue commit f9577df Author: Timo Kramer <[email protected]> Date: Tue Feb 25 15:38:05 2020 +0100 fixed malformed return of commit-image function commit 9d05e0d Author: Timo Kramer <[email protected]> Date: Tue Feb 25 12:41:14 2020 +0100 took functions to format CMD and ENV for passing to daemon commit 1217e31 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 18:50:08 2020 +0100 TODO added commit 5c33c05 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 14:05:13 2020 +0100 log-streaming implemented commit bef9118 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:17 2020 +0100 updated docker-client commit 1bfddf1 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:03 2020 +0100 timeouts added for docker connection commit 180262a Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:25:42 2020 +0100 bug filed for clj-docker on timeout on putcontainerarchive commit 4298a4f Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:36 2020 +0100 garbage collection repaired commit 2036b96 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:12 2020 +0100 refactored execution internals commit 5b3b25b Author: Timo Kramer <[email protected]> Date: Tue Feb 18 14:06:07 2020 +0100 fixed some tests commit a550949 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 11:36:02 2020 +0100 pipeline internals adapted commit fbf8a98 Author: Timo Kramer <[email protected]> Date: Mon Feb 17 17:55:39 2020 +0100 refactored commit-image into execution/internals and adapted pipeline/internals next-step to new clj-docker-client commit e7084b3 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:21:15 2020 +0100 failing test; dont know how to mock file commit 44acdb9 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:20:20 2020 +0100 made commit a state commit d9e003f Author: Timo Kramer <[email protected]> Date: Fri Feb 14 16:06:23 2020 +0100 resource internals adapted commit 74baf38 Author: Timo Kramer <[email protected]> Date: Mon Feb 10 16:01:08 2020 +0100 artifact/core adapted commit 6b81cce Author: Timo Kramer <[email protected]> Date: Mon Feb 10 12:44:52 2020 +0100 health check adapted commit 5c9f70b Author: Timo Kramer <[email protected]> Date: Thu Feb 6 17:50:31 2020 +0100 run function using new clj-docker commit 448df78 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:56:54 2020 +0100 improved build to use failjure return commit 1f89b75 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:22:16 2020 +0100 status-of function now using new clj-docker lib commit 8de9273 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 15:06:03 2020 +0100 validation for image name improved and container build implemented commit b8eda9d Author: Timo Kramer <[email protected]> Date: Tue Feb 4 15:01:02 2020 +0100 log-and-fail to avoid repetition commit d38ff6c Author: Timo Kramer <[email protected]> Date: Sun Feb 2 18:36:38 2020 +0100 pull image function refactored commit c7a4c66 Author: Timo Kramer <[email protected]> Date: Thu Jan 30 16:05:27 2020 +0100 switched to states commit 6d51bd2 Author: Timo Kramer <[email protected]> Date: Wed Jan 29 13:16:42 2020 +0100 kill-container commit d944ebc Author: Timo Kramer <[email protected]> Date: Wed Jan 29 10:51:55 2020 +0100 first function transitioned to clj-docker 0.4.0
lispyclouds
pushed a commit
that referenced
this issue
Mar 23, 2020
Since we had problems using this lib in bob, we decided to change the behaviour to connect everytime you call invoke. The connect function is now deprecated and only returns a map to avoid breaking the api. You still are able to use client like before but it is discouraged now to use connect and only using invoke is also sufficient. I moved the connect-function to the requests namespace because it is not part of the official api but is used with the fetch-function and therefore should reside with it. The panic! function has to be in the requests namespace as well because otherwise we would have a cyclic dependency. The documentation is changed accordingly and fetch needs to call the for now unofficial function connect*. Refers #20
Closed by #25 |
TimoKramer
added a commit
to TimoKramer/bob
that referenced
this issue
Mar 23, 2020
- Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 - Closes bob-cd#56 - Refers bob-cd#20 into-docker/clj-docker-client#20 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. A new connection is made everytime invoke is called with the new clj-docker-client. That solves the problem we had with the former version of the client-lib. The url bob connects to is now configured via env-var. Documentation shows handling of variables set globally. Squashed commit of the following: commit e6b5a8bad70bbe331dcebbf1cc4fa053bbc6167e Author: Timo Kramer <[email protected]> Date: Tue Mar 17 20:36:36 2020 +0100 using patched docker-lib to solve socket-problem commit 68b967459f9100f022b924cc5242dce09280c7d9 Author: Timo Kramer <[email protected]> Date: Tue Mar 17 15:57:32 2020 +0100 Revert "trying different things to solve socket problems" This reverts commit 57a335e. commit 57a335e Author: Timo Kramer <[email protected]> Date: Sun Mar 8 15:36:52 2020 +0100 trying different things to solve socket problems commit 21ad5f9 Author: Timo Kramer <[email protected]> Date: Fri Mar 6 13:15:51 2020 +0100 Upgraded clj-docker-client to 0.5.1 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes bob-cd#68 Most of the time it was sufficient to just change the function call to run docker/invoke with a map of options. The new client returns a message when there was a problem, so I needed to catch that to return a failjure. Tests had to be changed to keep up with the changed function calls. Still there is a multiplex-problem when pulling multiple images. Squashed commit of the following: commit 64b6a32 Author: Timo Kramer <[email protected]> Date: Thu Mar 5 20:23:18 2020 +0100 improved some tests commit 554fa11 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:06:08 2020 +0100 the errors were not printed correctly commit 0915bfe Author: Timo Kramer <[email protected]> Date: Tue Mar 3 15:05:45 2020 +0100 extra connection for a pull because experiencing Socket problems commit ab297d4 Author: Timo Kramer <[email protected]> Date: Tue Mar 3 01:02:04 2020 +0100 less delay because pipeline is passed and cannot be stopped commit a6c5c3a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 23:32:13 2020 +0100 logging was not working because of special chars commit 5fd3b69 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 14:15:12 2020 +0100 TODO was superfluous commit 47fc68a Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:24:55 2020 +0100 refactored run to start-container because more accurate commit 04d51c0 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:14:33 2020 +0100 cider-formatting commit 50ea2fc Author: Timo Kramer <[email protected]> Date: Mon Mar 2 12:11:08 2020 +0100 refactored function build to create-container because that is more accurate commit aec1d81 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 11:34:15 2020 +0100 comment corrected commit f7eb578 Author: Timo Kramer <[email protected]> Date: Mon Mar 2 10:58:07 2020 +0100 stream to artifact-store works now commit 509cbc9 Author: Timo Kramer <[email protected]> Date: Fri Feb 28 18:32:24 2020 +0100 bootstrap_wendy.sh fails on extracting the tar commit aed0816 Merge: 05e1d75 afa375b Author: Timo Kramer <[email protected]> Date: Fri Feb 28 14:50:09 2020 +0100 Merge remote-tracking branch 'bob/master' into bob-cd#68-upgrade-docker-client commit 05e1d75 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 16:24:10 2020 +0100 refactored commit e939327 Author: Timo Kramer <[email protected]> Date: Wed Feb 26 10:15:39 2020 +0100 mistake in health-check was always returning unhealthy or errored out on connection issue commit f9577df Author: Timo Kramer <[email protected]> Date: Tue Feb 25 15:38:05 2020 +0100 fixed malformed return of commit-image function commit 9d05e0d Author: Timo Kramer <[email protected]> Date: Tue Feb 25 12:41:14 2020 +0100 took functions to format CMD and ENV for passing to daemon commit 1217e31 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 18:50:08 2020 +0100 TODO added commit 5c33c05 Author: Timo Kramer <[email protected]> Date: Mon Feb 24 14:05:13 2020 +0100 log-streaming implemented commit bef9118 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:17 2020 +0100 updated docker-client commit 1bfddf1 Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:26:03 2020 +0100 timeouts added for docker connection commit 180262a Author: Timo Kramer <[email protected]> Date: Sun Feb 23 15:25:42 2020 +0100 bug filed for clj-docker on timeout on putcontainerarchive commit 4298a4f Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:36 2020 +0100 garbage collection repaired commit 2036b96 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 17:15:12 2020 +0100 refactored execution internals commit 5b3b25b Author: Timo Kramer <[email protected]> Date: Tue Feb 18 14:06:07 2020 +0100 fixed some tests commit a550949 Author: Timo Kramer <[email protected]> Date: Tue Feb 18 11:36:02 2020 +0100 pipeline internals adapted commit fbf8a98 Author: Timo Kramer <[email protected]> Date: Mon Feb 17 17:55:39 2020 +0100 refactored commit-image into execution/internals and adapted pipeline/internals next-step to new clj-docker-client commit e7084b3 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:21:15 2020 +0100 failing test; dont know how to mock file commit 44acdb9 Author: Timo Kramer <[email protected]> Date: Sat Feb 15 18:20:20 2020 +0100 made commit a state commit d9e003f Author: Timo Kramer <[email protected]> Date: Fri Feb 14 16:06:23 2020 +0100 resource internals adapted commit 74baf38 Author: Timo Kramer <[email protected]> Date: Mon Feb 10 16:01:08 2020 +0100 artifact/core adapted commit 6b81cce Author: Timo Kramer <[email protected]> Date: Mon Feb 10 12:44:52 2020 +0100 health check adapted commit 5c9f70b Author: Timo Kramer <[email protected]> Date: Thu Feb 6 17:50:31 2020 +0100 run function using new clj-docker commit 448df78 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:56:54 2020 +0100 improved build to use failjure return commit 1f89b75 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 16:22:16 2020 +0100 status-of function now using new clj-docker lib commit 8de9273 Author: Timo Kramer <[email protected]> Date: Thu Feb 6 15:06:03 2020 +0100 validation for image name improved and container build implemented commit b8eda9d Author: Timo Kramer <[email protected]> Date: Tue Feb 4 15:01:02 2020 +0100 log-and-fail to avoid repetition commit d38ff6c Author: Timo Kramer <[email protected]> Date: Sun Feb 2 18:36:38 2020 +0100 pull image function refactored commit c7a4c66 Author: Timo Kramer <[email protected]> Date: Thu Jan 30 16:05:27 2020 +0100 switched to states commit 6d51bd2 Author: Timo Kramer <[email protected]> Date: Wed Jan 29 13:16:42 2020 +0100 kill-container commit d944ebc Author: Timo Kramer <[email protected]> Date: Wed Jan 29 10:51:55 2020 +0100 first function transitioned to clj-docker 0.4.0
lispyclouds
pushed a commit
to bob-cd/bob
that referenced
this issue
Mar 23, 2020
* Upgraded clj-docker-client to 0.5.2 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes #68 - Closes #56 - Refers #20 into-docker/clj-docker-client#20
lispyclouds
pushed a commit
to bob-cd/bob
that referenced
this issue
Mar 23, 2020
* Upgraded clj-docker-client to 0.5.2 - Refactored the interfacing functions to use data-driven client - Added different connections for different tasks to multiplex - Amended tests to adapt to new client functions - Refactored some naming to be more precise - Closes #68 - Closes #56 - Refers #20 into-docker/clj-docker-client#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
hammock
Channel your inner Rich Hickey
help wanted
Extra attention is needed
Related to #19 I think your hunch was correct, basically I am starting a container attaching to the logs and then waiting on the container so I can follow the logs until completion.
because logs is watching the stream on conn and wait is using conn this is causing issues, creating conn2 and used that for logs and conn1 for all other steps and that seems to be working for now.
for my purposes this is fine, I guess might be worth a note some where unless you implement the multiplexing solution you talked about.
The text was updated successfully, but these errors were encountered: