Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: esm-bundler warning #997

Merged
merged 1 commit into from
May 1, 2022
Merged

improvement: esm-bundler warning #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/guide/advanced/optimization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ The `esm-bundler` builds now exposes global feature flags that can be overwritte

- `__VUE_I18N_FULL_INSTALL__` (enable/disable, in addition to vue-i18n APIs, components and directives all fully support installation: `true`)
- `__VUE_I18N_LEGACY_API__` (enable/disable vue-i18n legacy style APIs support, default: `true`)
- `__VUE_I18N_PROD_DEVTOOLS__` (enable/disable vue-devtools support in production, default: `false`)
- `__INTLIFY_PROD_DEVTOOLS__` (enable/disable `@intlify/devtools` support in production, default: `false`)

:::warning NOTICE
Expand Down
3 changes: 1 addition & 2 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ module.exports = {
__ESM_BROWSER__: false,
__NODE_JS__: true,
__FEATURE_FULL_INSTALL__: true,
__FEATURE_LEGACY_API__: true,
__FEATURE_ESM_BUNDLER_WARN__: true
__FEATURE_LEGACY_API__: true
},

// The maximum amount of workers used to run your tests. Can be specified as % or a number. E.g. maxWorkers: 10% will use 10% of your CPU amount + 1 as the maximum worker number. maxWorkers: 2 will use a maximum of 2 workers.
Expand Down
1 change: 0 additions & 1 deletion packages/global.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ declare let __FEATURE_PROD_VUE_DEVTOOLS__: boolean
declare let __FEATURE_PROD_INTLIFY_DEVTOOLS__: boolean
declare let __FEATURE_LEGACY_API__: boolean
declare let __FEATURE_FULL_INSTALL__: boolean
declare let __FEATURE_ESM_BUNDLER_WARN__: boolean

// for tests
declare namespace jest {
Expand Down
1 change: 0 additions & 1 deletion packages/size-check-vue-i18n/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const config = {
__VUE_PROD_DEVTOOLS__: false,
__VUE_I18N_LEGACY_API__: false,
__VUE_I18N_FULL_INSTALL__: false,
__VUE_I18N_PROD_DEVTOOLS__: false,
__INTLIFY_PROD_DEVTOOLS__: false,
'process.env.NODE_ENV': JSON.stringify('production')
}),
Expand Down
5 changes: 0 additions & 5 deletions packages/vue-i18n/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ The `esm-bundler` builds now exposes global feature flags that can be overwritte

- `__VUE_I18N_FULL_INSTALL__` (enable/disable, in addition to vue-i18n APIs, components and directives all fully support installation: `true`)
- `__VUE_I18N_LEGACY_API__` (enable/disable vue-i18n legacy style APIs support, default: `true`)
- `__VUE_I18N_PROD_DEVTOOLS__` (enable/disable vue-devtools support in production, default: `false`)
- `__INTLIFY_PROD_DEVTOOLS__` (enable/disable `@intlify/devtools` support in production, default: `false`)

> NOTE: `__INTLIFY_PROD_DEVTOOLS__` flag is experimental, and `@intlify/devtools` is WIP yet.
Expand All @@ -65,10 +64,6 @@ The build will work without configuring these flags, however it is **strongly re

Note: the replacement value **must be boolean literals** and cannot be strings, otherwise the bundler/minifier will not be able to properly evaluate the conditions.

## Other Feature Flags

- `__FEATURE_ESM_BUNDLER_WARN__` (Suppress / Not suppress feature flags recommended warnings in build for `esm-bulder`)

## :copyright: License

[MIT](http://opensource.org/licenses/MIT)
9 changes: 0 additions & 9 deletions packages/vue-i18n/src/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,10 @@ export function initFeatureFlags(): void {
getGlobalThis().__VUE_I18N_LEGACY_API__ = true
}

if (typeof __FEATURE_PROD_VUE_DEVTOOLS__ !== 'boolean') {
needWarn = true
getGlobalThis().__VUE_I18N_PROD_DEVTOOLS__ = false
}

if (typeof __FEATURE_PROD_INTLIFY_DEVTOOLS__ !== 'boolean') {
getGlobalThis().__INTLIFY_PROD_DEVTOOLS__ = false
}

if (__DEV__ && typeof __FEATURE_ESM_BUNDLER_WARN__ === 'boolean') {
needWarn = __FEATURE_ESM_BUNDLER_WARN__
}

if (__DEV__ && needWarn) {
console.warn(
`You are running the esm-bundler build of vue-i18n. It is recommended to ` +
Expand Down
3 changes: 1 addition & 2 deletions rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,11 @@ function createReplacePlugin(
? `__VUE_I18N_LEGACY_API__`
: true,
__FEATURE_PROD_VUE_DEVTOOLS__: isBundlerESMBuild
? `__VUE_I18N_PROD_DEVTOOLS__`
? `__VUE_PROD_DEVTOOLS__`
: false,
__FEATURE_PROD_INTLIFY_DEVTOOLS__: isBundlerESMBuild
? `__INTLIFY_PROD_DEVTOOLS__`
: false,
__FEATURE_ESM_BUNDLER_WARN__: true,
preventAssignment: false,
...(isProduction && isBrowserBuild
? {
Expand Down