Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace algolia with local search #1488

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

g1eny0ung
Copy link
Contributor

Ref: #1466.

@kazupon
Copy link
Member

kazupon commented Aug 9, 2023

Welcome contribution! ❤️
Thank you so much!

However, netlify has build errors 😢
You can see the build error logs:
https://app.netlify.com/sites/sad-lewin-6b6a91/deploys/64d35713fe12d60008d461c6

I think vue-i18n package root need "type": "module"

@kazupon kazupon added the Type: Documentation A documetation fixes label Aug 9, 2023
@g1eny0ung
Copy link
Contributor Author

Changing the root package.json will break some other package builds. In order not to introduce additional changes, refer to https://vitejs.dev/guide/troubleshooting.html#this-package-is-esm-only, I only rename the extension of config to .mts.

@kazupon
Copy link
Member

kazupon commented Aug 9, 2023

Hmm...
I did the build again with netlify (with cache clear) and the build succeeded and worked fine.
That error is weired … 😅

CI has passed!
I'll merge!

Thank you so much again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation A documetation fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants