Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/PATRO23-273 - roles and permissions #81

Merged
merged 19 commits into from
May 10, 2023
Merged

feature/PATRO23-273 - roles and permissions #81

merged 19 commits into from
May 10, 2023

Conversation

Rokerio
Copy link
Contributor

@Rokerio Rokerio commented May 7, 2023 •
edited
Loading

pzajaczkowski
pzajaczkowski suggested changes May 8, 2023
View reviewed changes
Copy link
Contributor

@pzajaczkowski pzajaczkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have much time so i may have missed few things but overall looks good. One thing that bothers me is fact that we have to create permission service in every single module. Maybe there is way to make it shared or sth.

@LukaszWinowicz LukaszWinowicz marked this pull request as draft May 9, 2023 04:28
@Rokerio Rokerio marked this pull request as ready for review May 9, 2023 20:12
@Rokerio Rokerio requested a review from pzajaczkowski May 10, 2023 13:02
@Rokerio
Merge branch 'dev' into feature/PATRO23-273-Roles-and-permissions
cc71cdf 
# Conflicts:
#	src/modules/budget/api/Controllers/BudgetController.cs
@Rokerio Rokerio merged commit dd4bbf0 into dev May 10, 2023
@Rokerio Rokerio deleted the feature/PATRO23-273-Roles-and-permissions branch May 10, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszWinowicz LukaszWinowicz LukaszWinowicz left review comments

@IzabelaPalubicka IzabelaPalubicka IzabelaPalubicka left review comments

@mateuszgiedzinski mateuszgiedzinski mateuszgiedzinski approved these changes

@pzajaczkowski pzajaczkowski pzajaczkowski approved these changes

@Kepeczsz Kepeczsz Awaiting requested review from Kepeczsz

@KlaudiaGajocha KlaudiaGajocha Awaiting requested review from KlaudiaGajocha

@mateuszmuszynski mateuszmuszynski Awaiting requested review from mateuszmuszynski

Assignees

@LukaszWinowicz LukaszWinowicz

@Rokerio Rokerio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rokerio @mateuszgiedzinski @LukaszWinowicz @IzabelaPalubicka @pzajaczkowski