This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Fixing bug initializing the ManufacturerDataMask #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing bug initializing the ManufacturerDataMask Bytes of the DataMask are initialised with 0b00000001 instead of 0b11111111, hence only the least significant bits of the filter and the result set are being compared. Effectively the FilterMask is just an even/odd filter for the selected bytes. Also added the iBeacon type identifier (0x02) as well as length byte (0x21) to the filter mask. I understand this is done in the onScanResult method @ScannerScanCallback, however, as type byte and length are fixed this will reduce
|
Thanks for sharing this! I'll review and merge this in our upcoming release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bytes of the DataMask are initialised with 0b00000001 instead of
0b11111111, hence only the least significant bit of the DataMask and the
result data are being compared. Effectively the current FilterMask is just an
even/odd filter for the selected bytes.
Also added the iBeacon type identifier (0x02) as well as length byte
(0x21) to the filter mask. I understand this is done in the
onScanResult method @ScannerScanCallback, however, as type byte and
length are fixed this will reduce unnecessary callbacks.