[_] Chore/add test for share guest signup #1447
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying drive-web with
|
| Latest commit: |
36102fc
|
| Status: | ⚡️ Build in progress... |
| @@ -158,9 +158,6 @@ function ShareGuestSingUpView(): JSX.Element { | |||
| const { email, password, token } = formData; | |||
| const { xUser, xToken, mnemonic } = await doRegisterPreCreatedUser(email, password, invitationId ?? '', token); | |||
|
|
|||
| // TODO: Remove or modify this when the backend is updated to add kyber keys | |||
There was a problem hiding this comment.
Is the backend ready then, right? If it is ready, then it looks good to me
There was a problem hiding this comment.
@larryrider it's a duplication. doRegisterPreCreatedUser also runs a parser inside
package.json
Outdated
| @@ -66,7 +65,7 @@ | |||
| "react-international-phone": "^4.3.0", | |||
| "react-live-chat-loader": "^2.8.2", | |||
| "react-loading-skeleton": "^2.2.0", | |||
| "react-pdf": "^7.7.3", | |||
| "react-pdf": "^9.0.0", | |||
There was a problem hiding this comment.
have you checked that this not break the pdf preview?
package.json
Outdated
| "resolutions": { | ||
| "react-scripts/webpack-dev-server/express/path-to-regexp": ">=0.1.12", | ||
| "react-scripts/workbox-webpack-plugin/workbox-build/rollup": ">=2.79.2", | ||
| "react-scripts/**/nth-check": ">=2.0.1", | ||
| "react-scripts/**/micromatch": ">=4.0.8", | ||
| "react-scripts/**/@babel/traverse": ">=7.23.2", | ||
| "react-scripts/**/follow-redirects": ">=1.15.6", | ||
| "@internxt/sdk/axios": ">=0.28.0", | ||
| "@internxt/inxt-js/axios": ">=0.28.0", | ||
| "@internxt/inxt-js/axios/follow-redirects": ">=1.15.6" |
There was a problem hiding this comment.
good one @TamaraFinogina 🥳
| vi.mock('app/core/services/local-storage.service', () => ({ | ||
| default: { | ||
| get: vi.fn(), | ||
| clear: vi.fn(), | ||
| getUser: vi.fn(), | ||
| set: vi.fn(), | ||
| }, | ||
| })); |
There was a problem hiding this comment.
nit: Maybe at some point we should move the mocks to mocks files to avoid repeating them in different tests.
There was a problem hiding this comment.
yeah, I was thinking about it, it's same mocks over and over (almost the same but still)
| const mockClearUser: UserSettings = { | ||
| uuid: 'mock-uuid', | ||
| email: '[email protected]', | ||
| privateKey: Buffer.from(decryptedPrivateKey).toString('base64'), | ||
| mnemonic: encryptedMockMnemonic, | ||
| userId: 'mock-userId', | ||
| name: 'mock-name', | ||
| lastname: 'mock-lastname', | ||
| username: 'mock-username', | ||
| bridgeUser: 'mock-bridgeUser', | ||
| bucket: 'mock-bucket', | ||
| backupsBucket: null, | ||
| root_folder_id: 0, | ||
| rootFolderId: 'mock-rootFolderId', | ||
| rootFolderUuid: undefined, | ||
| sharedWorkspace: false, | ||
| credit: 0, | ||
| publicKey: keys.ecc.publicKey, |
There was a problem hiding this comment.
for next times, maybe could extract the commont values to a one const and reuse it in the others
| @@ -158,9 +158,6 @@ function ShareGuestSingUpView(): JSX.Element { | |||
| const { email, password, token } = formData; | |||
| const { xUser, xToken, mnemonic } = await doRegisterPreCreatedUser(email, password, invitationId ?? '', token); | |||
|
|
|||
| // TODO: Remove or modify this when the backend is updated to add kyber keys | |||
| const parsedUser = parseUserSettingsEnsureKyberKeysAdded(xUser); | |||
There was a problem hiding this comment.
Is this parser no longer necessary? is it used somewhere or we could remove it?
There was a problem hiding this comment.
@CandelR it's also called inside doRegisterPreCreatedUser, so basically I called it twice
|
Description
parseUserSettingsEnsureKyberKeysAddedfromShareGuestSingUpViewbecausedoRegisterPreCreatedUseralready runs parseUserSettingsEnsureKyberKeysAdded prior to outputting the result.Related Issues
Related Pull Requests
Checklist
How Has This Been Tested?
Test for new user with Kyber keys
Test for old user without Kyber keys
Additional Notes