[PB-845]: feat/calculate-folder-size

[edisonjpadilla]

I'm using a recursive raw query to get each file of each folder belonging to folder father.

the properties that I used to filter in the query all have indexes; file.folder_uuid, folder.uuid, folder.parent_uuid, so improving the performance for each request.

[sg-gs]

Hey @edisonjpadilla, we can not list "all" the folders/files in a given folder. That does not scale well, as with more folders/files, the longer the query.

I do not see any abort option in case the time to make the sum is more than X seconds. This makes the proposed changes a security issue. Use the recursive query to traverse the tree and calculate a sum there. The database should do that. Also, add a timeout control to avoid long lasting queries to keep the database busy all the time.

[sg-gs]

And please, provide a description of the PR + the testing coverage for the new code >80%

[edisonjpadilla]

Hey @edisonjpadilla, we can not list "all" the folders/files in a given folder. That does not scale well, as with more folders/files, the longer the query.

I do not see any abort option in case the time to make the sum is more than X seconds. This makes the proposed changes a security issue. Use the recursive query to traverse the tree and calculate a sum there. The database should do that. Also, add a timeout control to avoid long lasting queries to keep the database busy all the time.

I'm just getting the folders uuids and sum file sizes by folders uuids, I thought to do the sum in the recursive query, but I didn't because of the readability of the code and the raw query.

TO DO:

1. Do the sum in the recursive query
2. Add a timeout in case it's taking more time than expected

[edisonjpadilla]

@sg-gs Why should we test the sequelize library? it has already been tested by the owners, we just should mocking the response and send the same response as is at the sequelize doc and test our code by that.

#259 (comment)

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
91.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud