-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PB-1379] Feat:password protected sharing #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb9bc9c
to
04ae624
Compare
This was referenced Dec 18, 2023
sg-gs
requested changes
Dec 19, 2023
…e64 validator to encryptedPassword
sg-gs
previously approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the labels of the tests to accommodate 'When, then' pattern. Apart from that is all OK.
7b1e0ba
to
6e43873
Compare
sg-gs
requested changes
Dec 21, 2023
6e43873
to
7d2cf88
Compare
|
|
sg-gs
approved these changes
Dec 21, 2023
apsantiso
pushed a commit
that referenced
this pull request
Jul 11, 2024
[PB-1379] Feat:password protected sharing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users need to share their public links with a password to protect their data. To accomplish this with zero knowledge, the next changes are proposed.
encryptedPassword
needs to be encrypted with the publiccode
(which we don't store).size
,plainName
andtype
).