add Wikipedia links from Wikidata #9991

RayBB · 2024-11-05T06:07:30Z

This PR does three things:

Add the (language aware) Wikipedia link
Adds the Wikidata link
Add the Google Scholar link

Originally, this was just going to be for Wikipedia but I quickly realized the code should be cleaned up and ready to handle multiple profiles since that's the main idea. We settled on Wikipedia because it's the most useful, Wikidata so it can point people where to edit, and Google Scholar because it's well known and only really applies to academics. It's a nice first step before we discuss what icons we want to show and the order.

Technical

We decided to statically host these few icons for now. However, we might do a cache from wikidata later when there are many more.
We also discussed using monochrome icons but our current iconsets don't have a lot of icons so we decided to punt on that decision until we figure out which profiles we want to show long term.

Testing

Add a Wikidata identifier to a profile and see the icons show up

Screenshot

Before	After

Stakeholders

@cdrini

RayBB · 2024-11-06T18:02:04Z

Dropping a bunch of profiles here we decided to leave out for the first version.


    {
        "icon_url": "https://upload.wikimedia.org/wikipedia/commons/5/5e/ResearchGate_icon_SVG.svg",
        "wikidata_property": "P2038",
        "label": "ResearchGate",
        "base_url": "https://www.researchgate.net/profile/",
    },
    {
        "icon_url": "https://upload.wikimedia.org/wikipedia/commons/0/06/ORCID_iD.svg",
        "wikidata_property": "P496",
        "label": "ORCID",
        "base_url": "https://orcid.org/",
    },
    {
        "icon_url": "https://upload.wikimedia.org/wikipedia/commons/c/c7/Google_Scholar_logo.svg",
        "wikidata_property": "P1960",
        "label": "Google Scholar",
        "base_url": "https://scholar.google.com/citations?user=",
    },
    {
        "icon_url": "https://upload.wikimedia.org/wikipedia/commons/6/66/Academia-logo-2021.svg",
        "wikidata_property": "P5715",
        "label": "Academia.edu",
        "base_url": "",
    },
    {
        "icon_url": "https://avatars.githubusercontent.com/u/2212508",
        "wikidata_property": "P6005",
        "label": "Muck Rack",
        "base_url": "https://muckrack.com/",
    },
    {
        "icon_url": "https://upload.wikimedia.org/wikipedia/commons/d/d5/Mastodon_logotype_%28simple%29_new_hue.svg",
        "wikidata_property": "P4033",
        "label": "Mastodon",
        "base_url": "https://fedirect.toolforge.org/?id=",
    },
    {
        "icon_url": "https://play-lh.googleusercontent.com/XXqfqs9irPSjphsMPcC-c6Q4-FY5cd8klw4IdI2lof_Ie-yXaFirqbNDzK2kJ808WXJk",
        "wikidata_property": "P4985",
        "label": "TMDB",
        "base_url": "https://www.themoviedb.org/person/",
    },
    {
        "icon_url": "https://upload.wikimedia.org/wikipedia/commons/c/cb/Cib-imdb_%28CoreUI_Icons_v1.0.0%29.svg",
        "wikidata_property": "P345",
        "label": "IMDb",
        "base_url": "https://www.imdb.com/name/",
    },
    {
        "icon_url": "https://upload.wikimedia.org/wikipedia/commons/c/ce/X_logo_2023.svg",
        "wikidata_property": "P2002",
        "label": "X (Twitter)",
        "base_url": "https://twitter.com/",
    },

openlibrary/core/wikidata.py

openlibrary/templates/authors/infobox.html

for more information, see https://pre-commit.ci

cdrini

The code looks good overall; I can't quite test it until the http proxy is set up on our servers so that they can make the wikidata network call. That should be happening in the next day or so (CC @jimchamp ).

Freso · 2024-11-21T06:23:31Z

openlibrary/core/wikidata.py

+                [
+                    {
+                        "url": f"{profile_config['base_url']}{value}",
+                        "icon_url": f"/static/images/identifier_icons/{profile_config["icon_name"]}",


Suggested change

"icon_url": f"/static/images/identifier_icons/{profile_config["icon_name"]}",

"icon_url": f"/static/images/identifier_icons/{profile_config['icon_name']}",

?

In python 3.12+, this is actually ok! They rewrote the parser to make f-strings more resilient :) https://peps.python.org/pep-0701/

Oooh. Neat!

Freso · 2024-11-21T06:30:00Z

openlibrary/core/wikidata.py

@@ -32,14 +42,10 @@ class WikidataEntity:
    labels: dict[str, str]
    descriptions: dict[str, str]
    aliases: dict[str, list[str]]
-    statements: dict[str, dict]
+    statements: dict[str, list[dict]]
    sitelinks: dict[str, dict]
    _updated: datetime  # This is when we fetched the data, not when the entity was changed in Wikidata


I know this is from a different PR, but would it make sense to call this _fetched or _last_fetched instead to avoid the ambiguity and need of the comment? (Probably also something for a different PR since, either way, it’s unrelated to adding Wikipedia links.)

Freso · 2024-11-21T06:39:24Z

openlibrary/templates/authors/infobox.html

+$def render_social_icon(url, icon_url, title):
+    <a href="$url" title="$_('View on %(site)s', site=title)">
+        <img class="profile-icon" src="$icon_url" alt="">


Suggested change

$def render_social_icon(url, icon_url, title):

<a href="$url" title="$_('View on %(site)s', site=title)">

<img class="profile-icon" src="$icon_url" alt="">

$def render_social_icon(url, icon_url, label):

<a href="$url" title="$_('View on %(site)s', site=label)">

<img class="profile-icon" src="$icon_url" alt="$label">

The alt property should describe/be a stand‐in for the image, so the social’s label is probably a good fit. (Also, changing the title to label to be consistent with how it’s named in the dict, since my first iteration of this had the function signature take an addition label property…)

In this case, because we have the title tag on the above anchor element, the image can be seen as purely presentational, and doesn't require an alt tag (or more specifically requires an alt="" tag to denote it's presentational). E.g. screen readers will read the title tag, I believe. But this is a bit of an edge case, so not entirely sure.

cdrini · 2024-11-22T17:56:43Z

openlibrary/templates/authors/infobox.html

@@ -14,6 +14,11 @@
            <td><span itemprop="$itemprop">$value</span></td>
        </tr>

+$def render_social_icon(url, icon_url, title):
+    <a href="$url" title="$_('View on %(site)s', site=title)">


Suggested change

<a href="$url" title="$_('View on %(site)s', site=title)">

<a href="$url" title="$_('View on %(site)s', site=title)" data-ol-link-track="AuthorSocialLink|$title">

For another PR: it would be nice to have analytics on this; can $title have spaces/etc we might need to strip?

cdrini

Ok this is now working with @jimchamp 's latest PR changes ! 🥳

alanvalenciagonzalez936 · 2024-11-24T04:06:00Z

El mié., 20 de noviembre de 2024 11:17 a. m., Drini Cami < ***@***.***> escribió:

…

***@***.**** commented on this pull request. ------------------------------ In openlibrary/templates/authors/infobox.html <#9991 (comment)> : > + <a href="$url"> + <img class="profile-icon" src="$icon_url" title="$title"> ⬇️ Suggested change - <a href="$url"> - <img class="profile-icon" src="$icon_url" title="$title"> + <a href="$url" title="$_('View on %(site)s', site=title)"> + <img class="profile-icon" src="$icon_url" alt=""> I think the title is more common <a> since that helps screen readers. Then on the image, you can set alt="" to make the image essentially presentation, since the actual info is the title (+ remove the title from the image). — Reply to this email directly, view it on GitHub <#9991 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BHO4HIRQ6RSAPRQEOTTLQF32BS72FAVCNFSM6AAAAABRFYVIVGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBZGI3DGMBQHA> . You are receiving this because you commented.Message ID: ***@***.***>

RayBB added 6 commits November 5, 2024 01:06

add wikipedia links from wikidata

3d008cb

get.locale

38d3f16

Improve wikipedia link layout

90475fb

render many social profiles

4a5d2a7

add more wikidata properties

fe6cf41

re-enable wikidata

a96700c

RayBB added 3 commits November 6, 2024 13:12

add function get wiki profiles

561e08d

remove all profiles beside Google Scholar

4ce051b

add icons

a3de553

cdrini reviewed Nov 6, 2024

View reviewed changes

openlibrary/core/wikidata.py Outdated Show resolved Hide resolved

openlibrary/templates/authors/infobox.html Outdated Show resolved Hide resolved

RayBB added 3 commits November 6, 2024 13:59

move css to less

b36762b

reoganize method names

3aeec6a

only render hr if we have wikidata

426ae2f

RayBB changed the title ~~add wikipedia links from wikidata~~ add Wikipedia links from Wikidata Nov 6, 2024

RayBB marked this pull request as ready for review November 6, 2024 19:23

add tests

1a3928d

RayBB mentioned this pull request Nov 6, 2024

Wikidata short descriptions aren't displaying in prod or locally #9992

Closed

alanvalenciagonzalez936 approved these changes Nov 7, 2024

View reviewed changes

internetarchive deleted a comment from alanvalenciagonzalez936 Nov 7, 2024

cdrini self-assigned this Nov 11, 2024

cdrini reviewed Nov 20, 2024

View reviewed changes

openlibrary/templates/authors/infobox.html Outdated Show resolved Hide resolved

cdrini and others added 2 commits November 20, 2024 12:17

Tweak accessibility of infobox.html

5e4172d

[pre-commit.ci] auto fixes from pre-commit.com hooks

7d6b654

for more information, see https://pre-commit.ci

cdrini approved these changes Nov 20, 2024

View reviewed changes

Freso reviewed Nov 21, 2024

View reviewed changes

Freso suggested changes Nov 21, 2024

View reviewed changes

cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Nov 21, 2024

cdrini reviewed Nov 22, 2024

View reviewed changes

cdrini approved these changes Nov 22, 2024

View reviewed changes

cdrini merged commit 5fb3126 into master Nov 22, 2024
7 checks passed

cdrini deleted the feature/9360-wikipedia-from-wikidata branch November 22, 2024 18:00

RayBB mentioned this pull request Nov 22, 2024

add tracking to wikidata infobox social links #10069

Merged

RayBB added the Module: Wikidata label Nov 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Wikipedia links from Wikidata #9991

add Wikipedia links from Wikidata #9991

RayBB commented Nov 5, 2024 •

edited

Loading

RayBB commented Nov 6, 2024

cdrini left a comment

Freso Nov 21, 2024

cdrini Nov 21, 2024

Freso Nov 21, 2024

Freso Nov 21, 2024

Freso Nov 21, 2024

cdrini Nov 22, 2024 •

edited

Loading

cdrini Nov 22, 2024 •

edited

Loading

cdrini left a comment

alanvalenciagonzalez936 commented Nov 24, 2024 via email

	"icon_url": f"/static/images/identifier_icons/{profile_config["icon_name"]}",
	"icon_url": f"/static/images/identifier_icons/{profile_config['icon_name']}",

	<a href="$url" title="$_('View on %(site)s', site=title)">
	<a href="$url" title="$_('View on %(site)s', site=title)" data-ol-link-track="AuthorSocialLink\|$title">

add Wikipedia links from Wikidata #9991

add Wikipedia links from Wikidata #9991

Conversation

RayBB commented Nov 5, 2024 • edited Loading

Technical

Testing

Screenshot

Stakeholders

RayBB commented Nov 6, 2024

cdrini left a comment

Choose a reason for hiding this comment

Freso Nov 21, 2024

Choose a reason for hiding this comment

cdrini Nov 21, 2024

Choose a reason for hiding this comment

Freso Nov 21, 2024

Choose a reason for hiding this comment

Freso Nov 21, 2024

Choose a reason for hiding this comment

Freso Nov 21, 2024

Choose a reason for hiding this comment

cdrini Nov 22, 2024 • edited Loading

Choose a reason for hiding this comment

cdrini Nov 22, 2024 • edited Loading

Choose a reason for hiding this comment

cdrini left a comment

Choose a reason for hiding this comment

alanvalenciagonzalez936 commented Nov 24, 2024 via email

RayBB commented Nov 5, 2024 •

edited

Loading

cdrini Nov 22, 2024 •

edited

Loading

cdrini Nov 22, 2024 •

edited

Loading