Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Browse Menu Padding #9988

Merged

Conversation

SivanC
Copy link
Contributor

@SivanC SivanC commented Nov 4, 2024

Shift padding from li wrapper to button element to increase clickable area of buttons in header browse menu.

Closes #9971

Fixes an issue where some vertical space on button in the header Browse dropdown menu was unclickable.

Technical

Shifted padding from li wrapper to a inner element in header-bar.less

Testing

  • Open the Browse menu on any screen
  • Confirm that, for each button, the top and bottom 5px are now clickable (excluding the border)

Screenshot

Image shows the new boundaries of the a clickable element in the browse menu:
image

Stakeholders

Shift padding from li wrapper to button element to increase clickable area of buttons in header browse menu.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.12%. Comparing base (ce16a79) to head (d446cbc).
Report is 511 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9988      +/-   ##
==========================================
+ Coverage   16.06%   17.12%   +1.06%     
==========================================
  Files          90       89       -1     
  Lines        4769     4752      -17     
  Branches      832      831       -1     
==========================================
+ Hits          766      814      +48     
+ Misses       3480     3428      -52     
+ Partials      523      510      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mekarpeles mekarpeles merged commit cb85ddb into internetarchive:master Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust padding of Browse dropdown menu to avoid dead space
3 participants