fail calls to openlibrary.php gracefully #9977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
commented
Nov 1, 2024
openlibrary/core/lending.py
Outdated
| @@ -1103,9 +1103,9 @@ def _post(self, **payload): | |||
| ).json() | |||
| logger.info("POST response: %s", jsontext) | |||
| return jsontext | |||
| except Exception: # TODO: Narrow exception scope | |||
| except (JSONDecodeError, Exception): # TODO: Narrow exception scope | |||
There was a problem hiding this comment.
We should split this into just JSONDecodeError and/or 403... And any other Exception and continue to raise
There was a problem hiding this comment.
We might also consider using timeout=1 or something to reduce the wait time for calls we know should be fast.
cdrini
requested changes
Nov 1, 2024
|
Mek tested, looks ok for now. |
cdrini
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Categorically fixes
IA_Lending_APIissue where Open Library breaks whenarchive.org/services/openlibrary.phpnot reachableWas discovered when trying to hit https://openlibrary.org/account/loans. Because
archive.org/services/openlibrary.phpis currently blocked by mod_security WAF, the API was hitting non-json 403 response and dying.Thie code path here was:
get_waitinglist_for_userin/openlibrary/openlibrary/core/waitinglist.pywhich died while trying to callwaitlist.extend(WaitingLoan.query(userid=account.itemname)). TheWaitingLoan.queryusescore.lending.IA_Lending_APIwhich has a_postmethod https://github.com/internetarchive/openlibrary/compare/master...php-graceful-failure?quick_pull=1#diff-896c18b3ccfadfa425c7e24a86226343314fce7957d14a8023d3e159156b224bL1092 which has been patched to return{}instead ofraisewhen a failure occurs.