Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed stylelint errors #9912

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

siddarth2810
Copy link
Contributor

@siddarth2810 siddarth2810 commented Sep 26, 2024

Closes #9792

Added min-width for textarea and made width take 100% space in desktop size.

Technical

This was the overlapping of CSS

screenshot-20240926-164448Z-selected

Removed overlapping CSS from static/css/components/form.olform.less

Added the below CSS in the static/css/page-edit.less

screenshot-20240926-183324Z-selected

Testing

Open static/css/components/form.olform.less and change the lines 230 to 234

Open static/css/page-edit.less and add min-width property at 161 line

Screenshot

screenshot-20240926-173757Z-selected

Stakeholders

@mekarpeles

@siddarth2810
Copy link
Contributor Author

Hi @mekarpeles, I would love to hear your thoughts on this and would really appreciate it if you could review this. Thanks !

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.44%. Comparing base (3025f5d) to head (cec6511).
Report is 62 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9912   +/-   ##
=======================================
  Coverage   17.44%   17.44%           
=======================================
  Files          89       89           
  Lines        4792     4792           
  Branches      848      848           
=======================================
  Hits          836      836           
  Misses       3436     3436           
  Partials      520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siddarth2810
Copy link
Contributor Author

Hey ! Should I make an another PR for this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textfield size in collections edit page
3 participants