Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement accessibilty suggestions for Onboarding carousel #10235

Conversation

schu96
Copy link
Contributor

@schu96 schu96 commented Dec 30, 2024

Closes #7848

Fix

Technical

Increases the text spacing between the header and subtitle text within the Onboarding carousel cards.

Changes the text color from grey hsl (330, 3%, 62%) to black hsl (0, 0%, 20%) to increase the contrast ratio

Testing

Navigate to localhost:8080 and use a web accessibility tool to verify that the contrast ratio should pass the WCAG 2.1 AA/AAA guidelines.

Screenshot

Before
392563749-80ec7801-b055-403f-9c8b-fe947160d96d
After
392562895-c32f552c-8e9f-44c1-8946-74a76586d9df

Stakeholders

@mekarpeles

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.44%. Comparing base (3025f5d) to head (3905879).
Report is 72 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10235      +/-   ##
==========================================
- Coverage   17.44%   17.44%   -0.01%     
==========================================
  Files          89       89              
  Lines        4792     4793       +1     
  Branches      848      849       +1     
==========================================
  Hits          836      836              
  Misses       3436     3436              
- Partials      520      521       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mekarpeles mekarpeles merged commit fbaef01 into internetarchive:master Jan 5, 2025
4 checks passed
@mekarpeles
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Low-contrast text in the carousel element on the top page
3 participants