Enable Ruff Rule: Remove unneeded occurrences of the global keyword

openlibrary/core/stats.py

@@ -38,15 +38,15 @@ def create_stats_client(cfg=config):
 
 def put(key, value, rate=1.0):
     "Records this ``value`` with the given ``key``. It is stored as a millisecond count"
-    global client
+
     if client:
         pystats_logger.debug(f"Putting {value} as {key}")
         client.timing(key, value, rate)
 
 
 def increment(key, n=1, rate=1.0):
     "Increments the value of ``key`` by ``n``"
-    global client
+
     if client:
         pystats_logger.debug("Incrementing %s" % key)
         for i in range(n):
@@ -62,7 +62,7 @@ def gauge(key: str, value: int, rate: float = 1.0) -> None:
 
     See https://statsd.readthedocs.io/en/v3.3/types.html#gauges
     """
-    global client
+
     if client:
         pystats_logger.debug(f"Updating gauge {key} to {value}")
         client.gauge(key, value, rate=rate)

openlibrary/plugins/openlibrary/stats.py

@@ -27,7 +27,7 @@
 def evaluate_and_store_stat(name, stat, summary):
     """Evaluates whether the given statistic is to be recorded and if
     so, records it."""
-    global filters
+
     if not summary:
         return
     try:
@@ -133,7 +133,7 @@ def process_stats(stats):
 
 
 def register_filter(name, function):
-    global filters
+
     filters[name] = function
 
 

openlibrary/plugins/upstream/borrow.py

@@ -253,7 +253,6 @@ class borrow_status(delegate.page):
     path = "(/books/.*)/_borrow_status"
 
     def GET(self, key):
-        global lending_subjects
 
         i = web.input(callback=None)
 
@@ -521,7 +520,6 @@ def get_loan_status(resource_id: str):
         }
     ]
     """
-    global loanstatus_url
 
     if not loanstatus_url:
         raise Exception('No loanstatus_url -- cannot check loan status')
@@ -551,7 +549,6 @@ def get_loan_status(resource_id: str):
 
 def get_all_loaned_out():
     """Returns array of BSS status for all resources currently loaned out (according to BSS)"""
-    global loanstatus_url
 
     if not loanstatus_url:
         raise Exception('No loanstatus_url -- cannot check loan status')
@@ -614,7 +611,6 @@ def _update_loan_status(loan_key, loan, bss_status=None) -> None:
 
 def update_loan_from_bss_status(loan_key, loan, status) -> None:
     """Update the loan status in the private data store from BSS status"""
-    global loan_fulfillment_timeout_seconds
 
     if not resource_uses_bss(loan['resource_id']):
         raise Exception(
@@ -669,7 +665,6 @@ def update_all_loan_status() -> None:
 
 def resource_uses_bss(resource_id: str) -> bool:
     """Returns true if the resource should use the BSS for status"""
-    global acs_resource_id_prefixes
 
     if resource_id:
         for prefix in acs_resource_id_prefixes:

openlibrary/solr/update.py

@@ -37,7 +37,6 @@
 
 @functools.cache
 def get_solr_updaters() -> list[AbstractSolrUpdater]:
-    global data_provider
     assert data_provider is not None
     return [
         # ORDER MATTERS

openlibrary/utils/open_syllabus_project.py

@@ -14,7 +14,6 @@ def get_osp_dump_location() -> Path | None:
     """
     Get whether the location of the Open Syllabus project counts dump
     """
-    global osp_dump_location
     return osp_dump_location
 
 

pyproject.toml

@@ -49,7 +49,6 @@ ignore = [
   "F841",
   "PERF401",
   "PIE790",
-  "PLW0602",
   "PLW0603",
   "PLW2901",
   "RUF001",

scripts/partner_batch_imports.py

@@ -118,7 +118,6 @@ class Biblio:
     VU VY VZ WA WC WI WL WM WP WT WX XL XZ ZF ZZ""".split()
 
     def __init__(self, data):
-        global required_fields
         self.REQUIRED_FIELDS = required_fields
 
         self.primary_format = data[6]

scripts/solr_updater.py

@@ -215,7 +215,6 @@ async def update_keys(keys):
         return 0
 
     # FIXME: Some kind of hack introduced to work around DB connectivity issue
-    global args
     logger.debug("Args: %s" % str(args))
     update.load_configs(args['ol_url'], args['ol_config'], 'default')