Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] pytest fixture naming to comply with PT021 #10231

Conversation

drona-gyawali
Copy link
Contributor

@drona-gyawali drona-gyawali commented Dec 30, 2024

Part of #10196

  • Improved readability and maintainability of pytest fixtures.
  • Standardized fixture structure by adopting yield-based cleanup where appropriate.

Technical

Testing

  • Ensured ruff check . passes without errors.
  • Run pre-commit run --all-files to see what needs to be fixed

Screenshot

N/A

Stakeholders

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change suggestion but otherwise this is great! Good job with this one :)

I think it certainly makes thinks clearer for someone working with these test 👍

Now we just need staff to review/merge.

openlibrary/mocks/mock_infobase.py Outdated Show resolved Hide resolved
@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Dec 30, 2024
@mekarpeles mekarpeles merged commit 2335e8c into internetarchive:master Dec 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Developers Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants