Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make locate button open worldcat in new tab #10146

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Make locate button open worldcat in new tab #10146

merged 1 commit into from
Dec 16, 2024
+1 −1

Conversation

SivanC
Copy link
Contributor

@SivanC SivanC commented Dec 13, 2024

Closes #10144

Makes the locate button open worldcat in a new tab

Technical

Added target=_blank to macros/LocateButton.html

Testing

  1. Navigate to a Locate cta button
  2. Ensure that clicking on it opens a worldcat link in a new tab

Screenshot

Stakeholders

@mekarpeles

jimchamp
jimchamp approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SivanC!

@jimchamp jimchamp merged commit d996d3f into internetarchive:master Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimchamp jimchamp jimchamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make locate button to open worldcat in new tab
2 participants
@SivanC @jimchamp