Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extra white space issue on book preview modals #10142

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openlibrary/macros/BookPreview.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@

$if render_once('book-preview-floater'):
<div class="hidden">
<div class="floater" id="bookPreview">
<div id="bookPreview">
<div class="book-preview">
<div class="floaterHead">
<h2>$_('Preview Book')</h2>
<a class="dialog--close" data-key="book_preview">&times;<span class="shift">$_("Close")</span></a>
</div>
<div class="iframe-container">
<div>
<iframe style="width:100%; height:515px"></iframe>
<p class="learn-more">
<a data-key="book_preview_learn_more"
Expand Down
Binary file added static/images/ListsDesktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/images/ListsMobile.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/images/MainPageDesktop.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/images/MainPageMobile.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/images/SearchBooksDesktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/images/SearchMobile.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/images/StudentLibraryDesktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/images/StudentLibraryMobile.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/images/TrendingDesktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/images/TrendingMobile.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
74 changes: 73 additions & 1 deletion static/manifest.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"short_name": "Open Library",
"name": "Open Library: A page for every book published",
"description": "An open, editable library catalog for every book published.",
"description": "An open, editable library catalog for every book published. Access millions of books instantly! Search, read, and borrow on the go!",
"icons": [
{
"src": "/static/images/openlibrary-192x192.png",
Expand Down Expand Up @@ -38,6 +38,78 @@
"text": "q"
}
},
"screenshots": [
{
"src": "./images/MainPageDesktop.jpeg",
"sizes": "1280x720",
"type": "image/png",
"form_factor": "wide",
"label": "Main Page Desktop"
},
{
"src": "./images/SearchBooksDesktop.png",
"sizes": "1280x720",
"type": "image/png",
"form_factor": "wide",
"label": "Search Books Desktop"
},
{
"src": "./images/StudentLibraryDesktop.png",
"sizes": "1280x720",
"type": "image/png",
"form_factor": "wide",
"label": "Student Library Desktop"
},
{
"src": "./images/TrendingDesktop.png",
"sizes": "1280x720",
"type": "image/png",
"form_factor": "wide",
"label": "Trending Desktop"
},
{
"src": "./images/ListsDesktop.png",
"sizes": "1280x720",
"type": "image/png",
"form_factor": "wide",
"label": "Lists Desktop"
},
{
"src": "./images/MainPageMobile.jpg",
"sizes": "360x640",
"type": "image/png",
"form_factor": "narrow",
"label": "Main Page Mobile"
},
{
"src": "./images/SearchMobile.jpg",
"sizes": "360x640",
"type": "image/png",
"form_factor": "narrow",
"label": "Search Books Mobile"
},
{
"src": "./images/StudentLibraryMobile.jpg",
"sizes": "360x640",
"type": "image/png",
"form_factor": "narrow",
"label": "Student Library Mobile"
},
{
"src": "./images/TrendingMobile.jpg",
"sizes": "360x640",
"type": "image/png",
"form_factor": "narrow",
"label": "Trending Mobile"
},
{
"src": "./images/ListsMobile.jpg",
"sizes": "360x640",
"type": "image/png",
"form_factor": "narrow",
"label": "Lists Mobile"
}
],
"shortcuts": [
{
"name": "My Books",
Expand Down
Loading