-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed CSS so that the audiobook text does not overlap with the icon #10112
base: master
Are you sure you want to change the base?
Changed CSS so that the audiobook text does not overlap with the icon #10112
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10112 +/- ##
==========================================
+ Coverage 17.12% 17.42% +0.29%
==========================================
Files 89 89
Lines 4752 4799 +47
Branches 831 847 +16
==========================================
+ Hits 814 836 +22
- Misses 3428 3444 +16
- Partials 510 519 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you @LouisSim ! I think we might have a regression with the button on search pages here 😁
How can I replicate that issue, I am not seeing any problems on the search page but I might be looking in the wrong place |
@LouisSim do you see any books with the audio option in your search result? Also have you run |
Yeah, now I see it, the books I was looking at didn't have the audio option. Thanks! |
…o prevent any unwanted styling on other buttons
for more information, see https://pre-commit.ci
@LouisSim I'm struggling with my local environment right now but will test with Drini next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @LouisSim ! One more fix I'll put on testing, and then we should be good to go!
Great, thank you so much! |
Closes #8899
Fix: Fixes issue with the text overlapping in mobile
Technical
Changed css as directed in #9066, this seems to work to resize the text so that there is no issue with the overlap with the icon.
Testing
docker compose up
// For running site
docker compose exec -e PYTHONPATH=. web bash -c "./scripts/copydocs.py --search 'author_key:OL9411725A' --search-limit 100"
// Adding data
http://localhost:8080/works/OL36891831W/
Start changing screen width
Screenshot
Stakeholders
@cdrini
@RayBB