Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set fixed image height for offline page #10036

Merged
merged 2 commits into from
Nov 19, 2024
Merged

set fixed image height for offline page #10036

merged 2 commits into from
Nov 19, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Nov 18, 2024

Closes #

I noticed the offline page always reflows when you refresh because the image height isn't fixed.
Set the image height to be fixed.

No visual changes.

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini assigned benbdeitch and cdrini and unassigned benbdeitch Nov 18, 2024
static/offline.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks @RayBB !

@cdrini cdrini merged commit 72d4547 into master Nov 19, 2024
4 of 5 checks passed
@cdrini cdrini deleted the RayBB-patch-3 branch November 19, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants