Enable registration #10021
Merged
Enable registration #10021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
force-pushed
the
enable-registration
branch
from
60bb025 to
ebd43c6
Compare
jimchamp
force-pushed
the
enable-registration
branch
from
c445d24 to
c035993
Compare
|
Nice this looks great! Ah hopefully the timeout were just flukes... 😬 Only feedback is can we put the flash message in the position it is on the login page? There it replace the google sign in button. |
jimchamp
force-pushed
the
enable-registration
branch
from
5ff446b to
38a66cf
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9987
Re-enables new account creation via Open Library.
Have confirmed that a new account can be created via OL and verified. Calls to login and create account can be long, and sometimes time out. Verification link failed the first time it was used, but worked on the second try. In short, things work but the experience not be the best.
Technical
Testing
Screenshot
Stakeholders