Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily remove "Add cover" affordance #10016

Closed
wants to merge 1 commit into from
Closed

Temporarily remove "Add cover" affordance #10016

wants to merge 1 commit into from

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Nov 9, 2024

Related to #10012

Removes "Add cover"/"Manage cover" affordances temporarily.

Technical

Testing

While logged in:

  1. Go to a book page.
  2. Hover over the book's cover image. Expect nothing to change (i.e. "Add cover" affordance doesn't appear).

Screenshot

Stakeholders

scottbarnes
scottbarnes approved these changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great idea. Looks good to me.

@cdrini cdrini self-assigned this Nov 11, 2024
@cdrini
Copy link
Collaborator

cdrini commented Nov 18, 2024

Working now, so should no longer be needed, woohoo!

@cdrini cdrini closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottbarnes scottbarnes scottbarnes approved these changes

Assignees

@cdrini cdrini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimchamp @cdrini @scottbarnes