Make debug=true use the features config in openlibrary.yml

[cdrini]

Closes https://github.com/internetarchive/olsystem/issues/223

Also has parts:

• Make debug=true handling actually use openlibrary.yml config infogami#224
• https://github.com/internetarchive/olsystem/pull/239

Technical

We have a features section in our openlibrary.yml, which has a debug feature which specifies the query parameter / value. But this was never being read from, and instead the literal value true was used. This lets the configuration work correctly so we can control the parameter from the openlibrary.yml file.

Testing

Screenshot

Note: This requires the infogami changes to be merged in first! Locally you can test this with the docker compose infogami local file.

Tested:

Add to openlibrary.yml:

features:
    debug:
        filter: queryparam
        name: debug
        value: "true"  # Note the quotes are important! Otherwise it'll never match :P

Introducing an error to an html template, $ x = 7 / 0 to status.html, and :

• going to http://localhost:8080/status does not show debug
• going to http://localhost:8080/status?debug=true does not show debug
• going to http://localhost:8080/status?debug=foobar does show debug

Introducing an error to an API page,

• going to http://localhost:8080/search.json?q=the does not show debug
• going to http://localhost:8080/search.json?q=the&debug=true does not show debug
• going to http://localhost:8080/search.json?q=the&debug=foobar does show debug

Stakeholders

[scottbarnes]

Looks good to me.