-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop Showing Pagination Buttons When There is only one page #10210
Comments
@SharkyBytes this looks good. I assigned you and you can go ahead and work on it. |
Hi @RayBB, @mekarpeles & @cdrini , I’ve implemented the fix you mentioned, Ray, and I wanted to share some updates along with a suggestion I’ve worked on. I’ve addressed the issue as per your request, but I also made an additional improvement that I believe aligns with how pagination is handled elsewhere in the application (e.g., on the Trending page Video). To give you a clear view, I’ve recorded two versions for comparison: ->The implementation based on your suggestion ->The version with my additional suggestion Could you please have a look and let me know your thoughts? I’d love to hear your feedback on both implementations and understand which one you feel works best. |
Problem
This issue of hiding the pager when there is only one page was proposed by @RayBB. I am raising the issue on his behalf.
I also believe that if certain buttons are unclickable, we should stop giving false indications to users. For example, when we are already on first page, there's no use in showing the 'First' and 'Previous' buttons, as they serve no purpose. It's better to avoid showing these buttons.
What do you think about this, @RayBB, @mekarpeles?
Reproducing the bug
Context
Breakdown
Requirements Checklist
Related files
Stakeholders
Instructions for Contributors
The text was updated successfully, but these errors were encountered: