Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBDEV-7261 Fix discrepancy affecting old year-only publish dates #418

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

latonv
Copy link
Contributor

@latonv latonv commented Jan 15, 2025

Currently the date published shown on result tiles can be off by one for older years that fall before the creation of the local time zone, due to quirks in how dates are interpreted. This PR fixes the display error by ensuring that year-only dates always refer to UTC and do not involve the local time zone.

Copy link

github-actions bot commented Jan 15, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-16 22:41 UTC

Copy link
Contributor

@rebecca-shoptaw rebecca-shoptaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the explanatory comments and new tests!

@latonv
Copy link
Contributor Author

latonv commented Jan 16, 2025

Addressing test failures in a separate ticket (they are unrelated to the current changes).

@latonv latonv merged commit 40a6a61 into main Jan 16, 2025
1 of 2 checks passed
@latonv latonv deleted the webdev7261-old-dates-bug branch January 16, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants