Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jsonp usage to make BR work with CSP #1358

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

cdrini
Copy link
Contributor

@cdrini cdrini commented Nov 22, 2024

No description provided.

Copy link
Contributor

@bfalling bfalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.28%. Comparing base (ce47c72) to head (9ba0f7c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/plugin.chapters.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1358   +/-   ##
=======================================
  Coverage   69.28%   69.28%           
=======================================
  Files          59       59           
  Lines        5088     5088           
  Branches     1072     1072           
=======================================
  Hits         3525     3525           
  Misses       1536     1536           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • chapters work
  • Search works
  • TTS works

@cdrini cdrini merged commit 31b029c into internetarchive:master Dec 2, 2024
8 of 10 checks passed
@cdrini cdrini deleted the rm-jsonp branch December 2, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants