Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

39 preliminary ae procedure #60

Merged
merged 6 commits into from
Jul 13, 2020
Merged

39 preliminary ae procedure #60

merged 6 commits into from
Jul 13, 2020

Conversation

cadojo
Copy link
Contributor

@cadojo cadojo commented Jul 11, 2020

Types of Changes

Please check off the kinds of changes included in this pull request.

Procedures

  • Adds new procedure documents
  • Modifies existing procedures
  • Removes procedures

Vehicle

  • Adds a new vehicle
  • Modifies an existing vehicle
  • Removes a vehicle

Code

  • Adds new code
  • Modifies existing code
  • Removes code

Unit Tests

  • Adds unit tests
  • Modifies existing unit tests
  • Removes unit tests

Miscellaneous

  • Add/modify supporting documents (e.g. README.md files, community documents, templates)
  • Other (explain in comment below)

Did you make sure to...

Vehicles

  • ensure modified vehicles don't break existing event sequence code
  • notify teams whose scripts depend on that vehicle file
  • N/A

Code

  • add safety checks for common crashes (e.g. division by zero)
  • N/A

Unit Tests

  • add new unit tests for any new code
  • N/A

Sequence Controller Tests

  • run the code with the existing sequence controllers and ensure nothing breaks
  • N/A

Miscellaneous

  • connect the issues this pull request closes (required)

cadojo and others added 5 commits June 30, 2020 23:07
Initial commit for preliminary ES1 procedure document.
* Adding summary from issue #15
* Adding intro to AE ES1
Incorporating feedback from @mdbernard on ES1.md.
@cadojo cadojo added the documentation Improvements or additions to documentation label Jul 11, 2020
@cadojo cadojo requested a review from wcyoung08 July 11, 2020 01:48
@cadojo
Copy link
Contributor Author

cadojo commented Jul 11, 2020

@wcyoung08 Lemme know what you think of my (very rough) ES2.md draft, and the revisions to ES1.md. We still have details to work out, but I vote we get this to a merge-able state and then merge as soon as we can. That way we can start working on code design, and that will also help us to sort out the technical details we still need.

proc/ascent-entry/ES1.md Show resolved Hide resolved
@mdbernard mdbernard merged commit 203465b into trunk Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants