Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intermix grant script #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add intermix grant script #3

wants to merge 1 commit into from

Conversation

ChristopherMacGown
Copy link
Contributor

No description provided.

@ChristopherMacGown ChristopherMacGown force-pushed the add_intermix_user_script branch from 782cfa5 to 6cc85cb Compare April 19, 2019 22:44
sgromoll
sgromoll reviewed Apr 23, 2019
View reviewed changes
Copy link

@sgromoll sgromoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for customers to run to allow us to connect, or for us to run for our own clusters?

@ChristopherMacGown
Copy link
Contributor Author

This is an optional replacement for our documented way for our customers to set up an intermix user for us to connect to.

paul94133
paul94133 reviewed Aug 15, 2019
View reviewed changes
Copy link
Contributor

@paul94133 paul94133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general feedback is before we host this up on our sign up flow is

  • we should have an option that doesn't require redshift API access
  • need a -h type option to show the input options with better descriptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul94133 paul94133 paul94133 left review comments

@sgromoll sgromoll sgromoll left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristopherMacGown @paul94133 @sgromoll