Change ConnectionConfiguration getXmlLang method #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkolesnikov-intermedia
force-pushed
the
core/connectiion/xml-lang
branch
from
bd706d4 to
4dfc063
Compare
vkolesnikov-intermedia
changed the title
vkolesnikov-intermedia
changed the title
vkolesnikov-intermedia
force-pushed
the
core/connectiion/xml-lang
branch
from
4dfc063 to
18ec864
Compare
krasnov-k
reviewed
Dec 20, 2023
| result = result + "-" + country; | ||
| } | ||
| } else { | ||
| result = country; |
There was a problem hiding this comment.
country can be empty here. Is it ok?
There was a problem hiding this comment.
Yes, it other branch. But I doubted about empty language.
Probably condition must be more simple, just:
if (!country.isEmpty()) {
result = result + "-" + country;
}
I'll fix
There was a problem hiding this comment.
No, getLanguage really can be empty
There was a problem hiding this comment.
Fixed, it's already handle above.
anikitin-intermedia
approved these changes
Dec 20, 2023
vkolesnikov-intermedia
force-pushed
the
core/connectiion/xml-lang
branch
2 times, most recently
from
abe1ff5 to
163e224
Compare
vkolesnikov-intermedia
force-pushed
the
core/connectiion/xml-lang
branch
from
163e224 to
7d3fd81
Compare
krasnov-k
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.