Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reenable integration tests #470

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: reenable integration tests #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4fb558
chore: reenable integration tests
Nov 22, 2018
d3d4c61
Merge branch 'master' into chore/reenable-integration-tests
Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ test:
- npm run lint
- XUNIT_FILE=${CIRCLE_TEST_REPORTS}/mocha.xml npm test --coverage -- -R spec-xunit-file
# Run integration test suite
# TODO: Re-enable integration tests once they are updated for ILPv4
# - if git log -1 --pretty=%B | grep -qF "[skip tests]"; then true; else npm run integration; fi
- if git log -1 --pretty=%B | grep -qF "[skip tests]"; then true; else npm run integration; fi
post:
- npm run report-coverage
deployment:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"lint": "tslint --project . && eslint test/*.test.js test/mocks/ test/helpers/",
"test": "nyc mocha",
"report-coverage": "nyc report --reporter=json && codecov -f coverage/*.json",
"integration": "integration-loader && integration all",
"integration": "integration-loader && integration all -- --exit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is --exit? I don't see it in https://github.com/interledgerjs/five-bells-integration-test/blob/master/src/bin/integration.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there are unterminated listeners lingering in tests/tested components (STREAM and possible Connector), Mocha 4 doesnt automatically exit the tests (mochajs/mocha#3044)

Adding the -- --exit passes the exit flag to mocha and allows the tests to exit correctly after finished running

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unterminated listeners seems like a bug that should be fixed, not sidestepped, but this is an alright stopgap.

"commitmsg": "commitlint -e $GIT_PARAMS"
},
"engines": {
Expand Down