Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resend routes to peer that rebooted #388

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Conversation

michielbdejong
Copy link
Contributor

No description provided.

@momerath42
Copy link

You'll have to change the RouteUpdate schema, but yeah, this should work

Copy link
Contributor

@sentientwaffle sentientwaffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the schema is updated and the tests pass.

@codecov-io
Copy link

codecov-io commented Aug 17, 2017

Codecov Report

Merging #388 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   83.48%   83.43%   -0.06%     
==========================================
  Files          33       33              
  Lines        1193     1195       +2     
  Branches      192      193       +1     
==========================================
+ Hits          996      997       +1     
- Misses        197      198       +1
Impacted Files Coverage Δ
src/lib/message-router.js 56.75% <50%> (-0.19%) ⬇️
src/lib/route-broadcaster.js 74.82% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74959dc...7c59188. Read the comment docs.

@michielbdejong michielbdejong merged commit 7e4189d into master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants