Debump and bump versions #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3f1a8de. This restores rather large spread of version numbers across the many crates. Signed-off-by: Joonas Koivunen <[email protected]>
for public api changes. Signed-off-by: Joonas Koivunen <[email protected]>
for public api changes Signed-off-by: Joonas Koivunen <[email protected]>
for public api changes. Signed-off-by: Joonas Koivunen <[email protected]>
it re-exports all of the api so any api breakage must be reflected on it's version. Signed-off-by: Joonas Koivunen <[email protected]>
for the past work, there have been no API breaking changes however. Signed-off-by: Joonas Koivunen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: #668, #557
This first reverts the commit which bumped the versions to 1.0.0, then bumps the minor versions for the crates we know have in the past identified have received breaking changes.
If you go through the invidiual commits you can see how much churn a single version bump causes. Given how the
interledgercrate depends on all public api across crates, it does make me think if it would be best for this codebase to just have non-crates.io softer releases as the current dependency jungle is quite thick, with the re-exports the breakage will be difficult to track.There's no hurry on my part, but this puts in code what I've been thinking recently and commenting on the issues.