Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send 'hello' message to peer when user newly adds it #92

Open
justmoon opened this issue Dec 1, 2016 · 9 comments
Open

Send 'hello' message to peer when user newly adds it #92

justmoon opened this issue Dec 1, 2016 · 9 comments
Milestone

Comments

@justmoon
Copy link
Contributor

justmoon commented Dec 1, 2016

ILP Kit should keep track of current peers as well as adding/removing peers via the database, not via the configuration.

That will allow us to do things like managing peers via the UI (to make it more user-friendly for the operator) and even have an API for adding peers.

@vhpoet
Copy link
Contributor

vhpoet commented Dec 9, 2016

TODO

  • Peer CRUD
  • Feed connector with db peers
  • Remove peers from the config file (ilp-kit-cli)
  • Peer editing
  • Graphic showing the balance (----- | --------------)
  • An invite link for the other side (fills in the form for them)

@vhpoet
Copy link
Contributor

vhpoet commented Feb 23, 2017

@sharafian is there a way to find out who has a one sided peering with you?

@justmoon
Copy link
Contributor Author

justmoon commented Feb 24, 2017

@vhpoet: You'll receive RPC messages for a prefix you won't know what to do with...

@sharafian: We could make sure that the first RPC message that plugin-virtual sends is a handshake request with the information Vahe needs to detect it as a peering attempt.

@vhpoet: What information should an aspiring peer send? Name, logo, currency?

@vhpoet
Copy link
Contributor

vhpoet commented Feb 24, 2017

@justmoon host and currency for now.

@justmoon
Copy link
Contributor Author

Let's also do limit.

@vhpoet
Copy link
Contributor

vhpoet commented Feb 27, 2017

@justmoon you mean a suggested limit ?

@justmoon
Copy link
Contributor Author

No, I mean the hello packet should include the limit that the other side set, no?

@justmoon
Copy link
Contributor Author

Talked to @vhpoet - the limit can already be queried and there is already code for querying it, so it makes no sense to include in the hello message.

@justmoon justmoon modified the milestone: v2.0 Mar 11, 2017
@michielbdejong michielbdejong changed the title Peers should be stored in database, not in configuration Send 'hello' message to peer when user newly adds it Apr 25, 2017
@michielbdejong
Copy link
Contributor

Peers are now stored in database, but we still need the 'hello' message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants