Add the ability to set a project root #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to strip the deployment path from Bugsnag errors, normalising all paths across multiple deployments. See: https://docs.bugsnag.com/platforms/php/other/configuration-options/#project-root
Stoux
commented
Sep 30, 2019
| // The root should be resolved by Magento | ||
| return $this->directoryList->getRoot(); | ||
| } else { |
There was a problem hiding this comment.
I thought about adding a } if else (is_dir($projectroot)) { check here, but figured this allows more flexibility? Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set a project root, bugsnag docs: https://docs.bugsnag.com/platforms/php/other/configuration-options/#project-root.
By either setting the absolute path or the value
truein theenv.phpfile you can set the project root in Bugsnag. Bugsnag will strip the paths from errors & exceptions, normalising the paths across all deployments.When the value
trueis entered, it will resolve the path using Magento's DirectoryList.