Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpantesters failure in t/unit/cart.t #28

Open
SysPete opened this issue Sep 26, 2015 · 3 comments
Open

cpantesters failure in t/unit/cart.t #28

SysPete opened this issue Sep 26, 2015 · 3 comments

Comments

@SysPete
Copy link
Member

SysPete commented Sep 26, 2015

Failed test 'fail update with non-integer quantity'
at t/unit/cart.t line 345.
expecting: Regexp ((?^:quantity))
found: normal exit
SysPete added a commit that referenced this issue Sep 26, 2015
@SysPete
add debug to t/unit/cart.t to help debug #28
67b0334
@racke
Copy link
Member

racke commented Sep 28, 2015

Output with latest code (from http://www.cpantesters.org/cpan/report/c34e7d32-6533-11e5-9e2f-fda7dfbfc7aa):

#   Failed test 'fail update with non-integer quantity'
#   at t/unit/cart.t line 348.
# expecting: Regexp ((?^:quantity))
# found: normal exit
# SKU01 quantity set 2.3 is: 2.3

#   Failed test 'no products returned'
#   at t/unit/cart.t line 353.
#          got: 1
#     expected: 0
# Looks like you failed 2 tests of 208.
t/unit/cart.t ............ 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/208 subtests

SysPete added a commit that referenced this issue Sep 28, 2015
@SysPete
use sub instead of Type::Tiny isa check for Product->quantity
fff7596 
Workaround for #28 until time is available to investigate fully.
SysPete added a commit that referenced this issue Sep 28, 2015
@SysPete
add extra check of quantity in Cart->update
892dae2 
Workaround for #28 until time is available to investigate fully.
SysPete added a commit that referenced this issue Feb 29, 2016
@SysPete
Improved workaround for GH #28
a0e5d29 
Seems there is an issue with Type::Tiny::XS Int check. If we stringify
Product quantity in the isa check then the assertion works correctly
whether Type::Tiny::XS is used or not. Sucks. Time to create a ticket
against Type::Tiny::XS...
@SysPete
Copy link
Member Author

SysPete commented Feb 29, 2016

This problem exists with Type::Tiny::XS starting at version 0.010.

@SysPete
Copy link
Member Author

SysPete commented Feb 29, 2016

https://rt.cpan.org/Ticket/Display.html?id=112571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@racke @SysPete