Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put deprecation warning together in one line #288

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Oct 26, 2020

Background

The existing deprecation warning contains a lot of funny whitespaces (maybe we should use <<~ instead of <<-), but I think the source of the problem is that the warning message is printed across multiple lines.

Changes

In this pull request, I'll put it together in one line by removing line breaks and all unnecessary spaces.

Before

This is a snippet of output from bundle exec rake:

.          [DEPRECATION] now assert_schema_conform check response schema only.
            but we will change check request and response in future major version.
            so if you want to conform response only, please use assert_response_schema_confirm,
            or you can suppress this message and keep old behavior by setting old_assert_behavior=true.
.          [DEPRECATION] now assert_schema_conform check response schema only.
            but we will change check request and response in future major version.
            so if you want to conform response only, please use assert_response_schema_confirm,
            or you can suppress this message and keep old behavior by setting old_assert_behavior=true.
...........................................................................

Finished in 3.028900s, 135.3627 runs/s, 263.1318 assertions/s.

After

.[DEPRECATION] now assert_schema_conform check response schema only. but we will change check request and response in future major version. so if you want to conform response only, please use assert_response_schema_confirm, or you can suppress this message and keep old behavior by setting old_assert_behavior=true.
.[DEPRECATION] now assert_schema_conform check response schema only. but we will change check request and response in future major version. so if you want to conform response only, please use assert_response_schema_confirm, or you can suppress this message and keep old behavior by setting old_assert_behavior=true.
................................................................................................................................

Finished in 3.032245s, 135.2134 runs/s, 262.8416 assertions/s.

@ota42y
Copy link
Member

ota42y commented Nov 7, 2020

Nice changes!!!! thanks!!!

@ota42y ota42y merged commit 62f6616 into interagent:master Nov 7, 2020
@r7kamura r7kamura deleted the feature/deprecation-style branch November 7, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants