support filepath option #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I add loading json file initialize option. #180 But we can decide it's JSON or YAML using file extension. So we can provide auto load option. 2.x support JSON file only, so it's useless method call but it will be good code on 3.x branch.
ota42y
force-pushed
the
feature/support_load_file
branch
from
84261a5 to
d126db2
Compare
yhirano55
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add loading json file initialize option.
#180
But we can decide it's JSON or YAML using file extension.
So we can provide auto load option.
2.x support JSON file only, so it's useless method call but it will be good code on 3.x branch.