Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added INKMailHandler for Mail and Google Mail #16

Merged
merged 1 commit into from
Dec 18, 2013
Merged

added INKMailHandler for Mail and Google Mail #16

merged 1 commit into from
Dec 18, 2013

Conversation

Leandros
Copy link
Contributor

No description provided.

@Leandros Leandros mentioned this pull request Dec 17, 2013

- (instancetype)init {
if (self = [super init]) {
self.subject = nil;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These initializations to nil aren't actually necessary. You can safely remove the custom init method entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sure. Does the property always defaults to nil? On some other platforms a lot initialised variables are initialised to rubbish. BOOL on iOS for example as well.

Edit: Yeah, ok. Properties defaults to nil.
How convenient. ;)

@lazerwalker
Copy link
Member

Great! Just left a few minor comments, then this should be good to go.

@Leandros
Copy link
Contributor Author

Isn't the message:// scheme for opening already received mails in Apples Mail.app?

@lazerwalker
Copy link
Member

Cool. One last minor thing — "Google Mail" should probably be renamed to Gmail, since that's what the app itself is called.

(I tried to do it myself, but it doesn't look like there's a good way for me to add to an in-progress PR for a fork I don't own)

@Leandros
Copy link
Contributor Author

HaHa. Had it called GMail, but renamed it to Google Mail. :D
Will revert it.

@lazerwalker
Copy link
Member

Cool. Just to clarify, the official spelling is 'Gmail', with a lowercase 'm'.

@Leandros
Copy link
Contributor Author

HA. That's difficult to change, with a non case-sensitive file system ...

@lazerwalker
Copy link
Member

Sorry to be such a fussbudget, but the name inside the plist is still "Google Mail".

Also, any chance you can squash these down to a single commit?

@lazerwalker
Copy link
Member

You should be able to do the filename changes with case sensitivity pretty easily in the Finder.

@Leandros
Copy link
Contributor Author

Squashed and passed test. Here you go. ;)

lazerwalker added a commit that referenced this pull request Dec 18, 2013
added INKMailHandler for Mail and Google Mail
@lazerwalker lazerwalker merged commit ff16438 into intentkit:master Dec 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants