This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
adds https ability to go rest client and pulsectl #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPS is available in two modes on the REST API: with a given certificate / key pair, or it can generate unsigned ones at start up. The client needs the ability to bypass cert signing errors when communicating with the API. In this commit a param is added when constructing a client instance called `insecure`. If this flag is given, the certificating signing errors are bypassed. When pulsectl constructs a client instance, it passes in the value of a new `--insecure` flag which provides pulsectl the same functionality described above.
|
LGTM (I initially thought the "error connecting to API.." error should be typed and wrapped in a perror which would capture the uri the request was using but I'm not sure it warrants changing 'do' to return a perror.) |
pittma
added a commit
that referenced
this pull request
Oct 7, 2015
adds https ability to go rest client and pulsectl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPS is available in two modes on the REST API: with a given certificate
/ key pair, or it can generate unsigned ones at start up. The client
needs the ability to bypass cert signing errors when communicating
with the API. In this commit a param is added when constructing a
client instance called
insecure. If this flag is given, thecertificating signing errors are bypassed.
When pulsectl constructs a client instance, it passes in the value of a
new
--insecureflag which provides pulsectl the same functionalitydescribed above.