This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
(SDI-2393) Fix #1448 log and document maxpluginrestarts #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRCody
reviewed
Jan 5, 2017
| "restart_count": pool.RestartCount(), | ||
| "_block": "handle-events", | ||
| "plugin-name": v.Name, | ||
| "plugin-version": v.Version, |
There was a problem hiding this comment.
I'm not clear what the difference is between v.Name + v.Version and v.String. Right before we log this we log an error with "aplugin": v.String. Not sure what the difference is but it seems like we should be consistent? I tried looking into core/control_event for the definitions of DeadAvailablePluginEvent but it's not commented on what the fields are meant to hold.
There was a problem hiding this comment.
I changed to v.String since that provides more info such as plugin type.
* support -1 for max_plugin_restarts, so it works better with max-failure: -1. * improve logging of MaxPluginRestarts so users are aware why a plugin is disabled. * document changes and relationship to max-failure settings.
IRCody
approved these changes
Jan 6, 2017
This was referenced Jan 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1448
Summary of changes:
Example of disabling plugin due to exceeding maxpluginrestartcount:
Testing done:
@intelsdi-x/snap-maintainers