This repository was archived by the owner on Nov 8, 2022. It is now read-only.
snappy dependency fix #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when sarma 1.4.2 will be released we should revert that fix and just update sarma to latests version |
|
👎 because we ignore vendored packages (scripts/deps.sh - does we have to wait, for sarma relaese that includes this fix or change how we use our vendored libraries |
ppalucki
force-pushed
the
snappy-dependency-fix
branch
from
a6f1e31 to
78918c5
Compare
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because of snappy unavailability on code.google.com
and that latest release of sarma 1.4.1 doesn't include fix from today IBM/sarama#455, I manually have fixed both godeps and vendored sarma code to work